From: Yixun Lan <dlan@kernel.org>
To: Hung-Chun Tseng <alan.tseng.cs@gmail.com>
Cc: Bruno Banelli <bbanelli@gmail.com>,
Eric Chung <eric.chung@riscstar.com>,
Tom Rini <trini@konsulko.com>, Guodong Xu <docular.xu@gmail.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Dave Klotz <DaveWK225@protonmail.com>,
u-boot@lists.u-boot-project.org, u-boot-spacemit@groups.io
Subject: Re: [PATCH v2] board: spacemit: k1: accept the "m1-x_" TLV product name prefix
Date: Mon, 16 Nov 2026 10:52:00 +0000 [thread overview]
Message-ID: <20261116105200-GKF100523@kernel.org> (raw)
In-Reply-To: <20261116071332.2637068-1-alan.tseng.cs@gmail.com>
Hi Hung-Chun,
On 15:13 Mon 16 Nov , Hung-Chun Tseng wrote:
> Hi Yixun,
>
> On Wed, 11 Nov 2026 21:36:41 +0000, Yixun Lan wrote:
> > board_fit_config_name_match() derives the device tree name from the TLV
> > product name held in the board EEPROM, and only recognises boards whose
> > product name starts with "k1-x_".
>
> After the rework this no longer matches the code: the mapping is now
> done in fixup_product_name() through k1_board_map, which matches full
> product names, not a "k1-x_" prefix.
>
> > The device trees are named for the K1 in both cases, so accept either
> > prefix and keep deriving a "k1-" name.
>
Right..
> The diff adds one entry for the Jupiter only, so an M1 MUSE Pi Pro or
> BPI-F3 would still fall back to the default. Maybe something like "Add
> the M1 Jupiter's product name to k1_board_map" for the subject and last
> paragraph?
>
I can adjust it
> Also, spacemit/k1-milkv-jupiter is not in CONFIG_OF_LIST on main, so
> neither Jupiter entry can find its device tree in the FIT yet. My
> Jupiter board patch adds it there.
>
Yes, we still need patches for supporting this board, give me some time,
I will review your patches
> The change itself looks fine to me.
>
Thanks
--
Yixun Lan (dlan)
prev parent reply other threads:[~2026-11-16 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 21:36 [PATCH v2] board: spacemit: k1: accept the "m1-x_" TLV product name prefix Yixun Lan
2026-11-13 10:49 ` Eric Chung
2026-11-16 7:13 ` Hung-Chun Tseng
2026-11-16 10:52 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116105200-GKF100523@kernel.org \
--to=dlan@kernel.org \
--cc=DaveWK225@protonmail.com \
--cc=alan.tseng.cs@gmail.com \
--cc=bbanelli@gmail.com \
--cc=docular.xu@gmail.com \
--cc=eric.chung@riscstar.com \
--cc=raymond.mao@riscstar.com \
--cc=trini@konsulko.com \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.