From: Leon Romanovsky <leon@kernel.org>
To: Eric Davis <eric.davis@broadcom.com>
Cc: sashiko-reviews@lists.linux.dev, linux-rdma@vger.kernel.org,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH rdma-next v3 11/13] RDMA/core: extended memory registration
Date: Mon, 16 Nov 2026 13:06:20 +0200 [thread overview]
Message-ID: <20261116110620.GG11319@unreal> (raw)
In-Reply-To: <CAMouMYLdU_5yphFCviPKUUieMDzo+ozVyAs+CJXTkh-0Zq0bYg@mail.gmail.com>
On Wed, Nov 11, 2026 at 08:46:32AM -0800, Eric Davis wrote:
> On Mon, Nov 9, 2026 at 9:55 PM <sashiko-bot@kernel.org> wrote:
> > Does ib_mr_init_core_refs() leave mr->dm, mr->dmah, and mr->sig_attrs
> > uninitialized when a driver returns a non-zeroed struct ib_mr?
>
> Those three are not new. The REG_MR and REG_DMABUF_MR handlers never
> set dm or sig_attrs, and set dmah only when one is given, so core
> already relies on a zeroed ib_mr from the driver for them. The helper
> covers the fields this series adds, which the extended paths and rereg
> read back. Its comment claims more than that; if there is another
> revision, it will say what the helper clears.
You are adding fields that should be NULL, there is no need to set them
and sashiko is right there.
Thanks
>
> > --
> > Sashiko AI review · https://sashiko.dev/#/patchset/20261109-uet-ib-core-v3-0-3e7e7ffed2e9@broadcom.com?part=11
>
> Thanks,
> - eric
next prev parent reply other threads:[~2026-11-16 11:06 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 4:00 [PATCH rdma-next v3 00/13] RDMA/core: Ultra Ethernet transport verbs Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 4:00 ` [PATCH rdma-next v3 01/13] RDMA/core: widen the uverbs object key Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 4:10 ` sashiko-bot
2026-11-10 4:00 ` [PATCH rdma-next v3 02/13] RDMA/core: add the UET GID types Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 4:21 ` sashiko-bot
2026-11-10 4:00 ` [PATCH rdma-next v3 03/13] RDMA/core: report the reliable unconnected device capabilities Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 4:25 ` sashiko-bot
2026-11-16 14:38 ` Michael Margolin
2026-11-10 4:00 ` [PATCH rdma-next v3 04/13] RDMA/core: add the reliable unconnected queue pair type Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 4:36 ` sashiko-bot
2026-11-16 14:41 ` Michael Margolin
2026-11-10 4:00 ` [PATCH rdma-next v3 05/13] RDMA/core: extended address handle attributes Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 4:45 ` sashiko-bot
2026-11-16 14:46 ` Michael Margolin
2026-11-10 4:00 ` [PATCH rdma-next v3 06/13] RDMA/core: query the semantics a queue pair type guarantees Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 4:49 ` sashiko-bot
2026-11-16 14:49 ` Michael Margolin
2026-11-10 4:00 ` [PATCH rdma-next v3 07/13] RDMA/core: job and job key objects Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 4:59 ` sashiko-bot
2026-11-10 4:00 ` [PATCH rdma-next v3 08/13] RDMA/uverbs: factor out the queue pair attribute copy Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 5:04 ` sashiko-bot
2026-11-10 4:00 ` [PATCH rdma-next v3 09/13] RDMA/core: create a queue pair ready to send Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 5:14 ` sashiko-bot
2026-11-16 14:53 ` Michael Margolin
2026-11-10 4:00 ` [PATCH rdma-next v3 10/13] RDMA/core: queue pair attributes for unconnected transports Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 5:29 ` sashiko-bot
2026-11-11 16:45 ` Eric Davis
2026-11-16 14:54 ` Michael Margolin
2026-11-10 4:00 ` [PATCH rdma-next v3 11/13] RDMA/core: extended memory registration Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 5:55 ` sashiko-bot
2026-11-11 16:46 ` Eric Davis
2026-11-16 11:06 ` Leon Romanovsky [this message]
2026-11-10 4:00 ` [PATCH rdma-next v3 12/13] RDMA/core: 64-bit memory keys Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 6:01 ` sashiko-bot
2026-11-10 4:00 ` [PATCH rdma-next v3 13/13] RDMA/core: attach a memory region to a queue pair Eric Davis
2026-11-10 4:00 ` Eric Davis via B4 Relay
2026-11-10 6:20 ` sashiko-bot
2026-11-11 16:49 ` Eric Davis
2026-11-16 14:36 ` [PATCH rdma-next v3 00/13] RDMA/core: Ultra Ethernet transport verbs Michael Margolin
2026-11-16 14:48 ` Jason Gunthorpe
2026-11-16 15:26 ` Michael Margolin
2026-11-16 16:03 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116110620.GG11319@unreal \
--to=leon@kernel.org \
--cc=eric.davis@broadcom.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.