From: Akshay Gupta <Akshay.Gupta@amd.com>
To: <linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>
Cc: <linux@roeck-us.net>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <corbet@lwn.net>,
<skhan@linuxfoundation.org>, <rdunlap@infradead.org>,
<arnd@arndb.de>, <gregkh@linuxfoundation.org>,
<naveenkrishna.chatradhi@amd.com>, <Anand.Umarji@amd.com>,
Prathima Lk <Prathima.Lk@amd.com>,
Akshay Gupta <Akshay.Gupta@amd.com>
Subject: [PATCH v1 2/4] dt-bindings: hwmon: add DIMM thermal sensor properties
Date: Mon, 16 Nov 2026 17:32:26 +0530 [thread overview]
Message-ID: <20261116120228.865196-3-Akshay.Gupta@amd.com> (raw)
In-Reply-To: <20261116120228.865196-1-Akshay.Gupta@amd.com>
From: Prathima Lk <Prathima.Lk@amd.com>
The SB-RMI mailbox also reports the temperature of the TS0/TS1 thermal
sensors on each DIMM (command 0x48, Mode 1 DIMM_ADDRESS). Boards differ
in how many DIMMs are fitted per memory channel and which sensors are
populated, so describe both in the binding.
Add two optional properties:
- amd,dpc: uint8, DIMMs per channel, 1 or 2 (default 1).
- amd,dimm-ids: uint8 array of 1 to 32 unique Mode 1 DIMM_ADDRESS
values, one per sensor to report. Encoding: bit[7]=1 (Mode 1),
bit[6] sensor (0=TS0, 1=TS1), bit[5] reserved, bit[4] DIMM slot,
bit[3:0] memory channel. When absent, the TS0 and TS1 sensors of
all 16 DIMMs are reported.
The allowed amd,dimm-ids values depend on amd,dpc: with one DIMM per
channel 0x80-0x8f and 0xc0-0xcf; with two, 0x80-0x87, 0x90-0x97,
0xc0-0xc7 and 0xd0-0xd7. This rejects the reserved bit, a slot bit
without a second DIMM, and channels above 7 with two DIMMs per channel.
Also mention the DIMM sensors in the title and description and extend
the example.
Signed-off-by: Prathima Lk <Prathima.Lk@amd.com>
Signed-off-by: Akshay Gupta <Akshay.Gupta@amd.com>
---
.../devicetree/bindings/hwmon/amd,sbrmi.yaml | 59 +++++++++++++++++--
1 file changed, 55 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml b/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml
index 353d81d89bf5..f08b62133996 100644
--- a/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml
+++ b/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml
@@ -4,9 +4,7 @@
$id: http://devicetree.org/schemas/hwmon/amd,sbrmi.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: >
- Sideband Remote Management Interface (SB-RMI) compliant
- AMD SoC power device.
+title: AMD SoC SB-RMI power and DIMM thermal sensor
maintainers:
- Akshay Gupta <Akshay.Gupta@amd.com>
@@ -16,7 +14,8 @@ description: |
interface that reports AMD SoC's Power (normalized Power) using,
Mailbox Service Request and resembles a typical 8-pin remote power
sensor's I2C interface to BMC. The power attributes in hwmon
- reports power in microwatts.
+ reports power in microwatts. The same mailbox also reports the
+ temperature of the TS0/TS1 thermal sensors on each populated DIMM.
properties:
compatible:
@@ -33,10 +32,60 @@ properties:
\[open source SoC register reference\]
https://www.amd.com/en/support/tech-docs?keyword=55898
+ amd,dpc:
+ $ref: /schemas/types.yaml#/definitions/uint8
+ enum: [1, 2]
+ default: 1
+ description:
+ DIMMs per channel (dimms-per-channel), the number of DIMM slots per
+ memory channel.
+
+ amd,dimm-ids:
+ $ref: /schemas/types.yaml#/definitions/uint8-array
+ minItems: 1
+ maxItems: 32
+ uniqueItems: true
+ description: |
+ Mode 1 SB-RMI DIMM_ADDRESS of each DIMM thermal sensor to report.
+ Encoding: bit[7]=1 (Mode 1), bit[6] sensor (0=TS0, 1=TS1), bit[5]
+ reserved, bit[4] DIMM slot, bit[3:0] memory channel ID. With one DIMM
+ per channel bit[4] is 0; with two, the memory channel ID is 0-7.
+ When absent, the TS0 and TS1 sensors of all 16 DIMMs are reported.
+
required:
- compatible
- reg
+allOf:
+ - if:
+ required:
+ - amd,dpc
+ properties:
+ amd,dpc:
+ const: 2
+ then:
+ properties:
+ amd,dimm-ids:
+ items:
+ anyOf:
+ - minimum: 0x80
+ maximum: 0x87
+ - minimum: 0x90
+ maximum: 0x97
+ - minimum: 0xc0
+ maximum: 0xc7
+ - minimum: 0xd0
+ maximum: 0xd7
+ else:
+ properties:
+ amd,dimm-ids:
+ items:
+ anyOf:
+ - minimum: 0x80
+ maximum: 0x8f
+ - minimum: 0xc0
+ maximum: 0xcf
+
additionalProperties: false
examples:
@@ -48,6 +97,8 @@ examples:
sbrmi@3c {
compatible = "amd,sbrmi";
reg = <0x3c>;
+ /* TS0 sensors of the DIMMs on memory channels 0-7 */
+ amd,dimm-ids = /bits/ 8 <0x80 0x81 0x82 0x83 0x84 0x85 0x86 0x87>;
};
};
...
--
2.34.1
next prev parent reply other threads:[~2026-11-16 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 12:02 [PATCH v1 0/4] misc: amd-sbi: add DIMM thermal sensors to sbrmi Akshay Gupta
2026-11-16 12:02 ` [PATCH v1 1/4] misc: amd-sbi: use guard() for data->lock mutex Akshay Gupta
2026-11-16 12:15 ` sashiko-bot
2026-11-16 12:02 ` Akshay Gupta [this message]
2026-11-16 12:11 ` [PATCH v1 2/4] dt-bindings: hwmon: add DIMM thermal sensor properties sashiko-bot
2026-11-16 12:02 ` [PATCH v1 3/4] misc: amd-sbi: add DIMM thermal sensor support Akshay Gupta
2026-11-16 12:13 ` sashiko-bot
2026-11-16 12:02 ` [PATCH v1 4/4] Documentation: hwmon: document DIMM thermal sensor channels Akshay Gupta
2026-11-16 12:08 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116120228.865196-3-Akshay.Gupta@amd.com \
--to=akshay.gupta@amd.com \
--cc=Anand.Umarji@amd.com \
--cc=Prathima.Lk@amd.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.