All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minxi Hou <houminxi@gmail.com>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: netdev@vger.kernel.org, Aaron Conole <aconole@redhat.com>,
	Eelco Chaudron <echaudro@redhat.com>,
	Ilya Maximets <i.maximets@ovn.org>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v4 0/2] net: openvswitch: fix a feature leak on a failed change
Date: Mon, 16 Nov 2026 07:32:19 -0500	[thread overview]
Message-ID: <20261116123219.1781480-1-houminxi@gmail.com> (raw)
In-Reply-To: <998d522f-e61d-420f-9834-6bdcbaab1361@kernel.org>

Hi Matt,

You are right about the hang, and it is mine. I reproduced it here.

To get a failure reason into the CI log I duplicated stdout onto fd 9 in
openvswitch.sh, because info() writes debug.log and a failing run
deletes that file. The suite starts daemons that outlive the script: the
per-vport upcall handlers from add-if -u, and the psample listener. They
inherit the second handle. runner.sh reads the test output from a pipe,
so as long as any process holds the write end, the pipe never reaches
EOF and the run sits there after the last subtest has already passed.

Redirecting the output to a file hides this completely, which is how I
ran it, and why I did not see it.

Writing those messages to stderr fixes it. stderr still reaches the
runner from inside ovs_sbx, and the daemons send both stdout and stderr
to files, so nothing is left holding the pipe.

Checked with the output piped the way runner.sh does it:

  before: "TEST: psample ... [ OK ]", then nothing until the timeout
  after:  21 tests [ OK ], and the run ends by itself
  with a wrong expectation injected: the reason still reaches the log and
  the test fails, so the diagnostics still work

The configs merge here as well. The only message is the CONFIG_IP_SCTP
m->y redefine, which is already in the fragment before this series.

I will send a v5 with this change.

Thanks,
Minxi

      reply	other threads:[~2026-11-16 12:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 16:31 [PATCH net v4 0/2] net: openvswitch: fix a feature leak on a failed change Minxi Hou
2026-11-15 16:31 ` [PATCH net v4 1/2] net: openvswitch: do not record user features when the change fails Minxi Hou
2026-11-16 16:33   ` netdev-bot+sashiko
2026-11-17 17:10     ` Minxi Hou
2026-11-15 16:31 ` [PATCH net v4 2/2] selftests/net/openvswitch: check that a failed set keeps the features Minxi Hou
2026-11-16 16:33   ` netdev-bot+sashiko
2026-11-15 20:12 ` [PATCH net v4 0/2] net: openvswitch: fix a feature leak on a failed change netdev-bot+sinfo
2026-11-16  1:32   ` Minxi Hou
2026-11-16 11:58 ` Matthieu Baerts
2026-11-16 12:32   ` Minxi Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116123219.1781480-1-houminxi@gmail.com \
    --to=houminxi@gmail.com \
    --cc=aconole@redhat.com \
    --cc=echaudro@redhat.com \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.