From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sebastian Ott <seott@redhat.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
Igor Mammedov <imammedo@redhat.com>,
Fiona Ebner <f.ebner@proxmox.com>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [RFC] Unrevert "PCI: acpiphp: Reassign resources on bridge if necessary"
Date: Mon, 16 Nov 2026 13:11:18 -0500 [thread overview]
Message-ID: <20261116131025-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <b59dadbc-035c-0a70-8947-bb0123bd5021@redhat.com>
On Mon, Nov 16, 2026 at 07:03:23PM +0100, Sebastian Ott wrote:
> On Mon, 16 Nov 2026, Michael S. Tsirkin wrote:
> > On Mon, Nov 16, 2026 at 05:52:23PM +0100, Sebastian Ott wrote:
> > > Hej Folks,
> > >
> > > using ACPI PCI hotplug with qemu on ARM for a device with a
> > > BAR > 2M fails because of a resource allocation failure in the
> > > guest kernel.
> > >
> > > Without ACPI hotplug the same usecase works because the native
> > > PCIe hotplug controller would increase the resource window of
> > > the parent PCI bus.
> > >
> > > X86 shows the same behavior but default resource window sizes
> > > are different and qemu can use ACPI DSM #5 to hint the guest
> > > to keep larger (predefined) resource windows.
> > >
> > > Efforts to adapt that behavior in qemu on ARM failed [1]
> > > because they've caused regressions elsewhere and maintainers
> > > thought that Linux hotplug controller should be changed.
> > >
> > > But this also has been tried before:
> > > 40613da52b13 ("PCI: acpiphp: Reassign resources on bridge if necessary")
> > >
> > > Unfortunately that led to regressions as well [2] and the patch was
> > > reverted:
> > > 5df12742b7e3 ("Revert "PCI: acpiphp: Reassign resources on bridge if necessary"")
> > >
> > > I've tried the reproducer mentioned in [2] using recent kernels for a
> > > couple 1000 times and didn't ran into issues.
> > >
> > > Could we give this patch another shot? Or does someone have another idea
> > > on how to make ACPI PCI hotplug work with large BARs without breaking
> > > something else.
> > >
> > > [1] https://lore.kernel.org/qemu-arm/0de640a2-8807-69cf-4429-672263e3e759@redhat.com/
> > > [2]
> > > https://lore.kernel.org/all/9eb669c0-d8f2-431d-a700-6da13053ae54@proxmox.com/
> > >
> > > Thanks,
> > > Sebastian
> >
> > Why would trying the same thing again lead to a different outcome?
> > At a minimum, I'd expect an explanation what changed.
>
> I couldn't reproduce the reported issue with scsi hotplug on recent
> kernels. I have not done a bisect though since I couldn't even build
> the kernel for which the issue was initially reported with recent
> toolchain. So I can't answer what exactly made the issue go away.
>
> Sebastian
Try reposting and including info on what testing you did.
--
MST
prev parent reply other threads:[~2026-11-16 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 16:52 [RFC] Unrevert "PCI: acpiphp: Reassign resources on bridge if necessary" Sebastian Ott
2026-11-16 17:12 ` Michael S. Tsirkin
2026-11-16 18:03 ` Sebastian Ott
2026-11-16 18:11 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116131025-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=bhelgaas@google.com \
--cc=f.ebner@proxmox.com \
--cc=imammedo@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=seott@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.