From: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
To: intel-xe@lists.freedesktop.org, matthew.brost@intel.com,
rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com,
airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com,
anoop.c.vijay@intel.com, badal.nilawar@intel.com,
matthew.d.roper@intel.com, james.ausmus@intel.com
Subject: [PATCH v16 00/17] Crescent Island PMT support
Date: Mon, 16 Nov 2026 07:06:49 -0800 [thread overview]
Message-ID: <20261116150649.368686-19-michael.j.ruhl@intel.com> (raw)
The Crescent Island (CRI) GPU supports PMT via Xe driver
registration.
The CRI PMT MMIO mapping is shared for each PMT feature and it is
necessary to set an index register value to access the correct memory
space.
The PMT driver has a callback infrastructure to access data areas with
driver specific access. It is does not support the PMT control access.
CRI discovery/control spaces are part of the access window so a driver
callback is necessary to allow for the correct window to be exposed.
Add control path callback support to the PMT driver.
Add CRI PMT discovery information.
Update the Xe driver to support the CRI PMT access.
The crashlog access needs to be done with power enabled (telem is only
available when the device is powered).
Determine which access is requested, and do the appropriate power
request.
CRI FW is loaded at device power. Support the late-binding API to
wait for FW readiness. (pending sysctl patch set implements the API).
v2:
Address AI feedback:
- add missing entry->cb check
- address SRIOV VF concerns
- use xe_pm_runtime_put instead of _get in error path
Address review comments:
- redo power/lock sequencing
- support device hotplug events
v3:
- cleanup power manangement flow
- fixed an out of order power management locking issue
- add a GUID caching mechanism, for GUID read
- removed unused parameter (mmio)
v4:
- address various review comments
- refactor crashlog to allow for return values
- for callback usage, decouple PMT remap of data areas
- use IS_SRIOV_VF() rather than expose soc-remapper internals
- separate locking fixes intos distinct steps
- refactor define update patches to seperate BMG and CRI updates
- separate internal GUID into separate steps
v5:
- removed callback helpers
- do not return error message with sysfs
- fix missed return code check in trigger_store
- return error value not false
- use DEFINE_RES_MEM
- document when base is unused
- return error on invalid GUID request
v6:
- fix enabled/disabled inversion
- fix missing DOC reference
- change memcpy_to/fromio to readl/writel for register read
- guid cache comment and update on valid guid
v7:
- reordered to have BMG updates followed by CRI support
- separate base_offset usage for clarity
- added EAGAIN usage to block uninitialized use of the API
v8:
- fix punit crashlog offset (should be 0xE60 not 0xE78)
- remove EAGAIN support and re-order probe steps to initialize
VSEC before other features use it
v9:
- added appropriate reviewed-bys
- use dev_err instead of pr_err
- enforce defined base usage when callbacks are in plcace
- move SRIOV check to get_platform_info
- assert SRIOV for API check
- use scoped_guard() where possible
- update to use correct sysctrl helper
v10:
- fix incorrect return type (broken in refactor, int -> bool)
- fix incorrectly documented error return values
- doc text cleanup
v11:
- add reviewed-by
- fix minor checkpatch issue
- use xe_assert() for a consistent API check
v12:
- add survivability mode support
- add reviewed-by
v13:
- PMT patches (original commits 1 - 5) are merged upstream
- resubmitting XeKMD patches
v14:
- address AI review comments
- init soc-remapper in survivability path
- reset soc-remapper index to the discovery index after access
- re-order read/write to eliminate need for goto
- check for signals in wait_for_fw
- add appropriate doc updates
- use system_freezable_wq vs system_wq
- cache survivability mode to avoid error path issues
v15:
- add/correct fixes tags
- replace devm_add with xe_vsec_remove() to avoid error path race
v16:
- fix xe_vsec_remove path to verify CRI usage before cleanup
Michael J. Ruhl (17):
drm/xe/vsec: VSEC requires soc-remapper
drm/xe/vsec: Do not register BMG PMT for VF
drm/xe/vsec: Correct locking order
drm/xe/vsec: Use correct pm state get
drm/xe/vsec: Add DOC text for VSEC
drm/xe/vsec: Support possible hotplug exit
drm/xe/vsec: Refactor BattleMage PMT defines
drm/xe/vsec: Update VSEC probe order
drm/xe/vsec: Add base_offset to allow for more flexibilty
drm/xe/vsec: Support Crescent Island PMT
drm/xe/vsec: Crescent Island PMT decode
drm/xe/vsec: Crescent Island PMT callbacks
drm/xe/vsec: Support late bind fw information
drm/xe/vsec: Add PMT GUID internal access
drm/xe/vsec: Update PMT internal access
drm/xe/vsec: Refactor platform check
drm/xe/vsec: Support survivability mode for CRI
Documentation/gpu/xe/index.rst | 1 +
Documentation/gpu/xe/xe_vsec.rst | 14 +
drivers/gpu/drm/xe/regs/xe_pmt.h | 12 +-
drivers/gpu/drm/xe/xe_debugfs.c | 45 +-
drivers/gpu/drm/xe/xe_device.c | 7 +-
drivers/gpu/drm/xe/xe_device_types.h | 11 +
drivers/gpu/drm/xe/xe_hwmon.c | 10 +-
drivers/gpu/drm/xe/xe_pcode.c | 10 +-
drivers/gpu/drm/xe/xe_survivability_mode.c | 2 +
drivers/gpu/drm/xe/xe_vsec.c | 590 +++++++++++++++++++--
drivers/gpu/drm/xe/xe_vsec.h | 2 +
11 files changed, 631 insertions(+), 73 deletions(-)
create mode 100644 Documentation/gpu/xe/xe_vsec.rst
--
2.43.0
next reply other threads:[~2026-11-16 15:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 15:06 Michael J. Ruhl [this message]
2026-11-16 15:06 ` [PATCH v16 01/17] drm/xe/vsec: VSEC requires soc-remapper Michael J. Ruhl
2026-11-16 15:06 ` [PATCH v16 02/17] drm/xe/vsec: Do not register BMG PMT for VF Michael J. Ruhl
2026-11-16 15:06 ` [PATCH v16 03/17] drm/xe/vsec: Correct locking order Michael J. Ruhl
2026-11-16 15:06 ` [PATCH v16 04/17] drm/xe/vsec: Use correct pm state get Michael J. Ruhl
2026-11-16 15:06 ` [PATCH v16 05/17] drm/xe/vsec: Add DOC text for VSEC Michael J. Ruhl
2026-11-16 15:06 ` [PATCH v16 06/17] drm/xe/vsec: Support possible hotplug exit Michael J. Ruhl
2026-11-16 15:06 ` [PATCH v16 07/17] drm/xe/vsec: Refactor BattleMage PMT defines Michael J. Ruhl
2026-11-16 15:06 ` [PATCH v16 08/17] drm/xe/vsec: Update VSEC probe order Michael J. Ruhl
2026-11-16 15:06 ` [PATCH v16 09/17] drm/xe/vsec: Add base_offset to allow for more flexibilty Michael J. Ruhl
2026-11-16 15:06 ` [PATCH v16 10/17] drm/xe/vsec: Support Crescent Island PMT Michael J. Ruhl
2026-11-16 15:07 ` [PATCH v16 11/17] drm/xe/vsec: Crescent Island PMT decode Michael J. Ruhl
2026-11-16 15:07 ` [PATCH v16 12/17] drm/xe/vsec: Crescent Island PMT callbacks Michael J. Ruhl
2026-11-16 15:07 ` [PATCH v16 13/17] drm/xe/vsec: Support late bind fw information Michael J. Ruhl
2026-11-16 15:39 ` sashiko-bot
2026-11-16 16:35 ` Ruhl, Michael J
2026-11-16 15:07 ` [PATCH v16 14/17] drm/xe/vsec: Add PMT GUID internal access Michael J. Ruhl
2026-11-16 15:31 ` sashiko-bot
2026-11-16 16:39 ` Ruhl, Michael J
2026-11-16 15:07 ` [PATCH v16 15/17] drm/xe/vsec: Update PMT " Michael J. Ruhl
2026-11-16 15:07 ` [PATCH v16 16/17] drm/xe/vsec: Refactor platform check Michael J. Ruhl
2026-11-16 15:07 ` [PATCH v16 17/17] drm/xe/vsec: Support survivability mode for CRI Michael J. Ruhl
2026-11-16 18:36 ` ✗ CI.checkpatch: warning for Crescent Island PMT support (rev18) Patchwork
2026-11-16 18:38 ` ✓ CI.KUnit: success " Patchwork
2026-11-16 19:10 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-17 5:52 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116150649.368686-19-michael.j.ruhl@intel.com \
--to=michael.j.ruhl@intel.com \
--cc=airlied@gmail.com \
--cc=anoop.c.vijay@intel.com \
--cc=badal.nilawar@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=james.ausmus@intel.com \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.