From: Brian Bunker <brian@purestorage.com>
To: Benjamin Marzinski <bmarzins@redhat.com>, Martin Wilck <mwilck@suse.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
dm-devel@lists.linux.dev
Subject: Re: [PATCH v4 1/1] multipathd: recheck WWIDs of re-added paths with the device
Date: Mon, 16 Nov 2026 10:43:08 -0800 [thread overview]
Message-ID: <20261116184308.24727-1-brian@purestorage.com> (raw)
In-Reply-To: <9259d20188a042cb280bad95f8be9783d1b9c1fd.camel@suse.com>
Martin, Ben,
Before I post a v5, here is where I stand on the open points, so we can
agree on a direction first.
On Fri, 2026-11-13, Martin Wilck wrote:
> We need to trust udev at some point, don't we?
Yes, and checking once is intentional: the check is meant to catch a
stale or wrong uevent, and the retriggered event carries fresh data.
In the code, uev_update_path() sets needs_reinit in two places: for
INIT_REQUESTED_UDEV, and for a changed udev WWID. I would pass
PATH_ADD_REINIT only from the changed-WWID branch. The retriggered event
then takes the normal path and trusts udev. No new init states or flags
are needed, and a persistently wrong ID_SERIAL can't cause repeated
checks.
> Yet another possibility is to introduce a new mode where we just never
> trust udev.
I would keep that out of this patch. It would add SG_IO calls to every
event, which is the stall risk you raised, and it deserves its own
discussion and data. It could become a value of recheck_wwid later.
> In my mind, a changed WWID followed by a failure to obtain the WWID
> from the device shows that something is really fishy about the path
> in question.
For this patch I side with Ben: if the check fails, trust what udev gave
us. A failed SG_IO on a path suggests the path is unhealthy, and
recheck_wwid will recheck it when it comes back up. Allowing a fallback
to SG_IO in get_uid() when udev fails seems reasonable to me as a
separate change.
> I suppose we could rescan asynchronously in this case.
I support that as a follow-up. On Purity, scan-scsi-target doesn't
refresh VPD for existing devices, so an explicit rescan is the only way
to correct stale sysfs data. I would rather not add it to this patch,
because it touches the regular changed-WWID path in uev_update_path().
So for v5 I plan to:
- lower the log level of the new message to 2 or 3,
- set pp->tick = conf->retrigger_delay, as pathinfo() does,
- limit the check to paths that are up, as Ben suggested,
- pass PATH_ADD_REINIT only from the changed-WWID branch.
Does that match what you have in mind?
Brian
next prev parent reply other threads:[~2026-11-16 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 18:16 [PATCH v4 0/1] multipathd: recheck WWIDs of re-added paths with the device Brian Bunker
2026-11-11 18:16 ` [PATCH v4 1/1] " Brian Bunker
2026-11-12 22:24 ` Martin Wilck
2026-11-13 18:00 ` Benjamin Marzinski
2026-11-13 20:52 ` Martin Wilck
2026-11-16 18:43 ` Brian Bunker [this message]
2026-11-16 22:19 ` Martin Wilck
2026-11-16 19:46 ` Benjamin Marzinski
2026-11-16 22:27 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116184308.24727-1-brian@purestorage.com \
--to=brian@purestorage.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.