All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mehmet Fide <mehmet.fide@gmail.com>
To: Luka Gejak <luka.gejak@linux.dev>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next v11 2/3] wifi: rtw88: support channel switch in AP mode
Date: Mon, 16 Nov 2026 22:49:09 +0100	[thread overview]
Message-ID: <20261116214909.1569237-1-mehmet.fide@gmail.com> (raw)
In-Reply-To: <59C03074-784F-41CE-A27D-EF3F30773D77@linux.dev>

Hi Luka,

All three are right, thanks.

> Could a failed download keep that count pending for a retry before
> allowing completion?

Yes. v12 downloads the same count again at the next step and calls
ieee80211_csa_finish() only after the count of 1 reached the firmware.
With the first download of a countdown failed on purpose and a count of
2, v11 switched with no CSA beacon on the air in 5 of 5 tries. v12 sent
every count in 30 of 30 with counts 2 and 5 on an RTL8821CU, an
RTL8822BU and an RTL8822CE.

> Maybe the refresh should not depend on csa_vif still being set?

v12 refreshes the page in rtw_ops_stop_ap() whenever a station interface
stays, and the work no longer clears csa_vif, only the driver ops do.

> Could the AP be found without allocating an entry?

v12 keeps the interface of the countdown in rtw_ops_suspend() and starts
it again in rtw_ops_resume(), without iterating.

Mehmet

  reply	other threads:[~2026-11-16 21:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:19 [PATCH rtw-next v11 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-11-16  7:19 ` [PATCH rtw-next v11 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-11-16  7:19 ` [PATCH rtw-next v11 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-11-16 14:24   ` Luka Gejak
2026-11-16 21:49     ` Mehmet Fide [this message]
2026-11-16  7:19 ` [PATCH rtw-next v11 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2026-11-16 14:26   ` Luka Gejak
2026-11-16 21:49     ` Mehmet Fide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116214909.1569237-1-mehmet.fide@gmail.com \
    --to=mehmet.fide@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luka.gejak@linux.dev \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.