From: James Lin <PingLei.Lin@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Harry Wentland <harry.wentland@amd.com>,
Leo Li <sunpeng.li@amd.com>,
Aurabindo Pillai <aurabindo.pillai@amd.com>,
Roman Li <roman.li@amd.com>, Wayne Lin <wayne.lin@amd.com>,
Tom Chung <chiahsuan.chung@amd.com>,
"Fangzhi Zuo" <jerry.zuo@amd.com>,
Dan Wheeler <daniel.wheeler@amd.com>, Ray Wu <Ray.Wu@amd.com>,
Ivan Lipski <ivan.lipski@amd.com>, Alex Hung <alex.hung@amd.com>,
James Lin <PingLei.Lin@amd.com>,
Chenyu Chen <Chen-Yu.Chen@amd.com>,
Dominik Kowalski <dominik.kowalski@amd.com>,
"James Lin" <pinglei.lin@amd.com>
Subject: [PATCH 11/33] drm/amd/display: Add DPMS-v2 types
Date: Tue, 17 Nov 2026 05:50:48 +0800 [thread overview]
Message-ID: <20261116215641.2800595-12-PingLei.Lin@amd.com> (raw)
In-Reply-To: <20261116215641.2800595-1-PingLei.Lin@amd.com>
From: Dominik Kowalski <dominik.kowalski@amd.com>
[Why]
DPMS-v2 replaces pipe_ctx with link_dpms_ctx, aiming to narrow its
reach and responsibilities, enabling more precise and safe design.
[How]
* Add link_tx in dedicated file as new vtable for DPMS-v2 to call
* Add link_dpms_ctx in core_types
* Place link_dpms_ctx in dc_link
* No initialization or other use logic yet, TBD
Signed-off-by: Dominik Kowalski <dominik.kowalski@amd.com>
Signed-off-by: James Lin <pinglei.lin@amd.com>
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +
.../gpu/drm/amd/display/dc/inc/core_types.h | 58 ++++++++++++++++++
drivers/gpu/drm/amd/display/dc/inc/link_tx.h | 59 +++++++++++++++++++
3 files changed, 119 insertions(+)
create mode 100644 drivers/gpu/drm/amd/display/dc/inc/link_tx.h
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index 01f549010d07..c9bdfba11a01 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -556,6 +556,7 @@ struct dc_update_descriptor {
struct dc;
struct dc_plane_state;
struct dc_state;
+struct link_dpms_ctx;
struct dc_cap_funcs {
bool (*get_dcc_compression_cap)(const struct dc *dc,
@@ -1931,6 +1932,7 @@ struct dc_scratch_space {
void *priv;
struct ddc_service *ddc;
+ struct link_dpms_ctx *dpms_ctx;
enum dp_panel_mode panel_mode;
bool panel_mode_initialized;
diff --git a/drivers/gpu/drm/amd/display/dc/inc/core_types.h b/drivers/gpu/drm/amd/display/dc/inc/core_types.h
index 695eaa5cbf65..1d6bb41312b7 100644
--- a/drivers/gpu/drm/amd/display/dc/inc/core_types.h
+++ b/drivers/gpu/drm/amd/display/dc/inc/core_types.h
@@ -31,6 +31,7 @@
#include "dcn_calcs.h"
#include "ddc_service_types.h"
#include "dc_bios_types.h"
+#include "dsc/dsc.h"
#include "mem_input.h"
#include "hubp.h"
#include "hw/dchubbub.h"
@@ -807,4 +808,61 @@ struct dc_update_scratch_space {
int intermediate_count;
};
+/**
+ * Snapshot of fields from dc_stream_state relevant to link_set_dpms_on_v2().
+ *
+ * Removes dependency on mutable stream object, which would otherwise create
+ * synchronization hazards.
+ */
+struct link_dpms_stream_descriptor {
+ // TODO: Implement
+ int dummy;
+};
+
+/**
+ * DPMS operation context variables.
+ *
+ * This struct is owned by dc_link, sharing its lifetime.
+ * The caller populates the context with update details and validates it.
+ * No other code aside from DPMS sequence itself is allowed to modify it during
+ * execution, while DPMS serialization prevents concurrent reuse.
+ *
+ * This struct is used by top-level link_set_dpms_on/off_v2() and the sequence
+ * steps link_dpms_step_xxx(). The step functions unpack relevant values
+ * and pass them directly as arguments into TX and HWSS. This is done to make
+ * TX and HWSS independent from DPMS, while preventing them from backtracking
+ * to shared state like DC and its state structs.
+ */
+struct link_dpms_ctx {
+ /**
+ * Mutable link state.
+ *
+ * Steps use it to record protocol results and evaluate preconditions.
+ * Should not be used to access dc_state, dc_stream_state, pipe_ctx.
+ */
+ struct dc_link *link;
+
+ /**
+ * Snapshot of relevant fields from dc_stream_state.
+ *
+ * Removes dependency on mutable stream object.
+ */
+ struct link_dpms_stream_descriptor stream_descriptor;
+
+ /**
+ * Stable validated link configuration.
+ *
+ * If unable to reach desired state, DPMS reports failure instead
+ * of rewriting alternative configuration.
+ */
+ struct link_config link_config;
+
+ /**
+ * Source-side link HW transmitter.
+ *
+ * This is sole interface used to program all protocol operations.
+ */
+ const struct link_tx *tx;
+};
+
#endif /* _CORE_TYPES_H_ */
diff --git a/drivers/gpu/drm/amd/display/dc/inc/link_tx.h b/drivers/gpu/drm/amd/display/dc/inc/link_tx.h
new file mode 100644
index 000000000000..3b671eea15ef
--- /dev/null
+++ b/drivers/gpu/drm/amd/display/dc/inc/link_tx.h
@@ -0,0 +1,59 @@
+/*
+ * Copyright 2026 Advanced Micro Devices, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * Authors: AMD
+ *
+ */
+#ifndef LINK_TX_H
+#define LINK_TX_H
+
+#include "dc/inc/core_types.h"
+#include "dc/inc/core_status.h"
+
+struct dc_link;
+struct link_resource;
+struct link_tx;
+struct link_tx_funcs;
+
+/**
+ * Private DPMS v2 context, opaque type forward-declared only.
+ */
+struct link_tx_v2_ctx;
+
+struct link_tx {
+ const struct link_tx_funcs *funcs;
+ struct dc_link *link;
+ struct link_tx_v2_ctx *ctx;
+};
+
+/**
+ * Virtual table of function pointers for link protocol programming.
+ *
+ * Analogous to HWSS, but takes link_tx instead of pipe_ctx, as the latter
+ * was deemed too broad and open, resulting in synchronization hazards.
+ */
+struct link_tx_funcs {
+ // TODO: Implement
+ void (*destroy)(struct link_tx *tx);
+};
+
+#endif
+
--
2.43.0
next prev parent reply other threads:[~2026-11-17 17:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 21:50 [PATCH 00/33] DC Patches November 23, 2026 James Lin
2026-11-16 21:50 ` [PATCH 01/33] drm/amd/display: Clear OTG_AUTO_FORCE_VSYNC_MODE on OTG disable James Lin
2026-11-16 21:50 ` [PATCH 02/33] drm/amd/display: Rename DPMS to DPMS_v1 James Lin
2026-11-16 21:50 ` [PATCH 03/33] drm/amd/display: Power up eDP when detect link James Lin
2026-11-16 21:50 ` [PATCH 04/33] drm/amd/display: Add DPMS-v2 files James Lin
2026-11-16 21:50 ` [PATCH 05/33] drm/amd/display: Refactor DP retrain link HW sequence James Lin
2026-11-16 21:50 ` [PATCH 06/33] drm/amd/display: add extra 0.25 line reserved for TSetup/TCalc inefficiency James Lin
2026-11-16 21:50 ` [PATCH 07/33] drm/amd/display: Use panel luminance range for AUX backlight in power module James Lin
2026-11-16 21:50 ` [PATCH 08/33] drm/amd/display: Read PWM back linearly with the linear backlight curve James Lin
2026-11-16 21:50 ` [PATCH 09/33] drm/amd/display: Add API to set brightness percent James Lin
2026-11-16 21:50 ` [PATCH 10/33] drm/amd/display: Pass linear brightness percent to power module James Lin
2026-11-16 21:50 ` James Lin [this message]
2026-11-16 21:50 ` [PATCH 12/33] drm/amd/display: Always apply 0ppm pixel clock adjustment James Lin
2026-11-16 21:50 ` [PATCH 13/33] drm/amd/display: Add otg versions of get_vblank_counter/scanoutpos James Lin
2026-11-16 21:50 ` [PATCH 14/33] drm/amd/display: Queue vblank control work to sleepable context James Lin
2026-11-16 21:50 ` [PATCH 15/33] drm/amd/display: Fix KUnit tests for vblank control rework James Lin
2026-11-16 21:50 ` [PATCH 16/33] drm/amd/display: Add urgent request and assertion probes James Lin
2026-11-16 21:50 ` [PATCH 17/33] drm/amd/display: Fix G7 P-state aperture addresses James Lin
2026-11-16 21:50 ` [PATCH 18/33] drm/amd/display: Set stream min/max refresh from VRR config James Lin
2026-11-16 21:50 ` [PATCH 19/33] drm/amd/display: Add DC2 wrapped initialization for DCN401 James Lin
2026-11-16 21:50 ` [PATCH 20/33] drm/amd/display: Honor the Replay stream regeneration wait event James Lin
2026-11-16 21:50 ` [PATCH 21/33] drm/amd/display: Disable Replay when link off frame count is below 2 James Lin
2026-11-16 21:50 ` [PATCH 22/33] drm/amd/display: Skip DSC padding borrow estimate for zero padding James Lin
2026-11-16 21:51 ` [PATCH 23/33] drm/amd/display: Drop unused DC interfaces James Lin
2026-11-16 21:51 ` [PATCH 24/33] drm/amd/display: Let the DC2 commit replace or keep a stream James Lin
2026-11-16 21:51 ` [PATCH 25/33] drm/amd/display: Support two streams in the dcn401 DC2 builders James Lin
2026-11-16 21:51 ` [PATCH 26/33] drm/amd/display: Add a plane beside a kept plane in DC2 update James Lin
2026-11-16 21:51 ` [PATCH 27/33] drm/amd/display: Keep an unchanged stream in the DC2 commit James Lin
2026-11-16 21:51 ` [PATCH 28/33] drm/amd/display: Change the ODM and MPC layout in DC2 update James Lin
2026-11-16 21:51 ` [PATCH 29/33] drm/amd/display: Give the DC2 builders State pipe facts James Lin
2026-11-16 21:51 ` [PATCH 30/33] drm/amd/display: Add RGBA8888 surface pixel format support James Lin
2026-11-16 21:51 ` [PATCH 31/33] drm/amd/display: Fix DCE crossbar for RGBA8888 surface format James Lin
2026-11-16 21:51 ` [PATCH 32/33] drm/amd/display: [FW Promotion] Release 0.1.85.0 James Lin
2026-11-16 21:51 ` [PATCH 33/33] drm/amd/display: Promote DC to 3.2.408 James Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116215641.2800595-12-PingLei.Lin@amd.com \
--to=pinglei.lin@amd.com \
--cc=Chen-Yu.Chen@amd.com \
--cc=Ray.Wu@amd.com \
--cc=alex.hung@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=daniel.wheeler@amd.com \
--cc=dominik.kowalski@amd.com \
--cc=harry.wentland@amd.com \
--cc=ivan.lipski@amd.com \
--cc=jerry.zuo@amd.com \
--cc=roman.li@amd.com \
--cc=sunpeng.li@amd.com \
--cc=wayne.lin@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.