All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Pranjal Shrivastava <praan@google.com>
Cc: Nicolin Chen <nicolinc@nvidia.com>,
	Kevin Tian <kevin.tian@intel.com>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, Peter Shier <pshier@google.com>,
	iommu@lists.linux.dev
Subject: Re: [PATCH v2] iommu: Honor iommufd uapi for zero entry_num args
Date: Mon, 16 Nov 2026 19:41:31 -0400	[thread overview]
Message-ID: <20261116234131.GF2245175@nvidia.com> (raw)
In-Reply-To: <avtoJ88ELacDrquz@google.com>

On Mon, Nov 16, 2026 at 08:31:35PM +0000, Pranjal Shrivastava wrote:
> > > Also, the selftests check exactly that [2]. An unsupported data_type gets
> > > -EINVAL from the drivers today, not -EOPNOTSUPP (happy to switch if you
> > > prefer).
> > 
> > EINVAL should only mean that the data inside the struct is
> > invalid, but everything else is understood. If the enum itself is not
> > known that has to be EOPNOTSUPP
> > 
> 
> I see! I'll respin the patch to return -EOPNOTSUPP for an unknown
> data_type (copy helpers, intel/selftest invalidation ops and the
> selftests) and fix the uAPI comment to say the probe should look for
> -EOPNOTSUPP. Does that sound fine?

Yes

Jason

      reply	other threads:[~2026-11-16 23:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 15:10 [PATCH v2] iommu: Honor iommufd uapi for zero entry_num args Pranjal Shrivastava
2026-11-13 17:54 ` Nicolin Chen
2026-11-16 11:27   ` Pranjal Shrivastava
2026-11-16 13:08     ` Jason Gunthorpe
2026-11-16 20:21       ` Pranjal Shrivastava
2026-11-16 20:23         ` Jason Gunthorpe
2026-11-16 20:31           ` Pranjal Shrivastava
2026-11-16 23:41             ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116234131.GF2245175@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=nicolinc@nvidia.com \
    --cc=praan@google.com \
    --cc=pshier@google.com \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.