From: Matt Turner <mattst88@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>,
Magnus Lindholm <linmag7@gmail.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
Matt Turner <mattst88@gmail.com>
Subject: [PATCH v3 2/7] alpha: marvel: report environmental events without VERBOSE_MCHECK
Date: Tue, 17 Nov 2026 13:13:29 -0500 [thread overview]
Message-ID: <20261117-marvel-env-v3-2-0edc370fdca9@gmail.com> (raw)
In-Reply-To: <20261117-marvel-env-v3-0-0edc370fdca9@gmail.com>
The service processors report temperature, fan, voltage and power supply
alarms as system event (0x680) logout frames. The frame is already
classified as reportable, but without CONFIG_VERBOSE_MCHECK only the
header line reaches the log, which does not say which sensor or what
happened. Print the subpackets unconditionally.
Signed-off-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Magnus Lindholm <linmag7@gmail.com>
---
arch/alpha/kernel/err_marvel.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/alpha/kernel/err_marvel.c b/arch/alpha/kernel/err_marvel.c
index 9304ae74877d..46c521cea9a0 100644
--- a/arch/alpha/kernel/err_marvel.c
+++ b/arch/alpha/kernel/err_marvel.c
@@ -21,7 +21,6 @@
#include "err_impl.h"
#include "proto.h"
-#ifdef CONFIG_VERBOSE_MCHECK
static const char *
marvel_env_state(u16 state)
{
@@ -34,12 +33,10 @@ marvel_env_state(u16 state)
default: return "unrecognized";
}
}
-#endif /* CONFIG_VERBOSE_MCHECK */
static void
marvel_print_680_frame(struct ev7_lf_subpackets *lf_subpackets)
{
-#ifdef CONFIG_VERBOSE_MCHECK
struct ev7_pal_environmental_subpacket *env;
struct { int type; char *name; } ev_packets[] = {
{ EL_TYPE__PAL__ENV__AMBIENT_TEMPERATURE,
@@ -70,7 +67,6 @@ marvel_print_680_frame(struct ev7_lf_subpackets *lf_subpackets)
marvel_env_state(env->state), env->cabinet,
env->drawer, env->pe, env->sensor, env->state);
}
-#endif /* CONFIG_VERBOSE_MCHECK */
}
static int
--
2.56.1
next prev parent reply other threads:[~2026-11-17 18:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 18:13 [PATCH v3 0/7] alpha: marvel: environmental sensors Matt Turner
2026-11-17 18:13 ` [PATCH v3 1/7] alpha: marvel: fix the environmental subpacket layout Matt Turner
2026-11-17 18:17 ` sashiko-bot
2026-11-17 20:11 ` Magnus Lindholm
2026-11-17 18:13 ` Matt Turner [this message]
2026-11-17 18:18 ` [PATCH v3 2/7] alpha: marvel: report environmental events without VERBOSE_MCHECK sashiko-bot
2026-11-17 18:13 ` [PATCH v3 3/7] alpha: marvel: refresh environmental readings through the console Matt Turner
2026-11-17 18:20 ` sashiko-bot
2026-11-17 20:12 ` Magnus Lindholm
2026-11-17 18:13 ` [PATCH v3 4/7] alpha: marvel: notify environmental events Matt Turner
2026-11-17 18:18 ` sashiko-bot
2026-11-17 18:13 ` [PATCH v3 5/7] alpha: marvel: register a platform device for the environmental sensors Matt Turner
2026-11-17 18:18 ` sashiko-bot
2026-11-17 18:13 ` [PATCH v3 6/7] hwmon: Add driver for Marvel AlphaServer " Matt Turner
2026-11-17 18:26 ` sashiko-bot
2026-11-17 21:00 ` Magnus Lindholm
2026-11-17 18:13 ` [PATCH v3 7/7] hwmon: (marvel-env) Notify userspace of environmental events Matt Turner
2026-11-17 18:26 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117-marvel-env-v3-2-0edc370fdca9@gmail.com \
--to=mattst88@gmail.com \
--cc=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.