From: Luo Liu <Luo.Liu@cixtech.com>
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Luo.Liu@cixtech.com, wuyi.shen@cixtech.com,
cix-kernel-upstream@cixtech.com
Subject: [PATCH v2 0/2] drm/cix: add Sky1 DisplayPort transmitter
Date: Tue, 17 Nov 2026 14:45:50 +0800 [thread overview]
Message-ID: <20261117064552.85256-1-Luo.Liu@cixtech.com> (raw)
Add the CIX Sky1 DisplayPort transmitter as a DRM bridge. The USB-C
transmitters and the native DP/eDP transmitter use separate compatibles
because their RCSU video-adapter layouts differ. The Sky1 devicetree
nodes are not included in this posting.
Scope: DPTX hardware and bindings only. Komeda (the Sky1 display
controller that feeds these bridges) and the board DTS are separate
series. Nothing in this posting wires a full display stack.
Connector handling in this driver:
The Komeda display pipeline (ARM Mali DPU on Sky1, posted separately)
calls drm_bridge_attach() with attach flags 0 and does not register a
connector for these DP outputs. This driver therefore registers a
DisplayPort drm_connector from bridge .attach(). Detect, EDID read, mode
enumeration and validation run through drm_connector_funcs and helper
hooks on that connector.
v1 -> v2:
- Split the compatible into "cix,sky1-usbdp" and "cix,sky1-dp", and
rename the binding to cix,sky1-dp.yaml.
- Drop cix,adapter-port, cix,stream-id and cix,dp-max-rate. Every
transmitter uses stream 0, and the maximum link rate is HBR2.
- Require phys and port in the binding; example follows Sky1-Orion graph
(DPU pipeline@0 to DPTX, USB-C dp-port PHY).
- Keep only the documented DPTX node in the binding example; reference
the DPU and USB-C PHY through phandles instead of copying their nodes.
- Allow COMPILE_TEST.
- Serialize mode selection with link retraining, and roll back the PHY
and the IRQ disable depth when enable or resume fails.
- Pair phy_init/phy_exit with host_init/deinit; use phy_power_on/off
only from core_on/off.
- Stop active streams before host teardown on remove and shutdown.
- Match YCbCr 4:2:0 against the original CEA mode, and avoid a 64-bit
division in the pixel-clock adjustment.
- Initialize train_done before the clock-recovery and channel-equalization
loops.
- Serialize sessions with a plain mutex and AUX with a separate lock
instead of a hand-written recursive lock; use ops->session_lock in DRM
paths and _locked helpers for the internal steps. Document the
session_lock -> aux_lock order.
- Roll back the bridge enable path with an explicit unprepare step when
mode selection or stream enable fails.
- Poll the PHY ready status with readl_poll_timeout(), check only the
AUX reply field that matches the request type, and drop the redundant
DPCD power-up retry loop.
- Wait for AUX reply with readl_poll_timeout(); register devm teardown
via devm_add_action_or_reset().
- Document INTERRUPT_CAUSE read-to-clear (Sky1 TRM).
- Use GENMASK()/FIELD_PREP() for adapter format fields; drop unused
link-training parameters.
Luo Liu (2):
dt-bindings: display: add CIX Sky1 DisplayPort transmitter
drm/cix: add Sky1 DisplayPort transmitter driver
.../bindings/display/cix,sky1-dp.yaml | 99 +
MAINTAINERS | 9 +
drivers/gpu/drm/Kconfig | 1 +
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/cix/Kconfig | 3 +
drivers/gpu/drm/cix/Makefile | 3 +
drivers/gpu/drm/cix/dptx/Kconfig | 17 +
drivers/gpu/drm/cix/dptx/Makefile | 4 +
drivers/gpu/drm/cix/dptx/cix_dptx.c | 2434 +++++++++++++++++
drivers/gpu/drm/cix/dptx/cix_dptx.h | 408 +++
drivers/gpu/drm/cix/dptx/cix_dptx_drm.c | 771 ++++++
drivers/gpu/drm/cix/dptx/cix_dptx_drm.h | 16 +
12 files changed, 3766 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/cix,sky1-dp.yaml
create mode 100644 drivers/gpu/drm/cix/Kconfig
create mode 100644 drivers/gpu/drm/cix/Makefile
create mode 100644 drivers/gpu/drm/cix/dptx/Kconfig
create mode 100644 drivers/gpu/drm/cix/dptx/Makefile
create mode 100644 drivers/gpu/drm/cix/dptx/cix_dptx.c
create mode 100644 drivers/gpu/drm/cix/dptx/cix_dptx.h
create mode 100644 drivers/gpu/drm/cix/dptx/cix_dptx_drm.c
create mode 100644 drivers/gpu/drm/cix/dptx/cix_dptx_drm.h
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
next reply other threads:[~2026-11-17 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 6:45 Luo Liu [this message]
2026-11-17 6:45 ` [PATCH v2 1/2] dt-bindings: display: add CIX Sky1 DisplayPort transmitter Luo Liu
2026-11-17 6:58 ` sashiko-bot
2026-11-17 6:45 ` [PATCH v2 2/2] drm/cix: add Sky1 DisplayPort transmitter driver Luo Liu
2026-11-17 7:36 ` sashiko-bot
2026-11-18 3:52 ` Chaoyi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117064552.85256-1-Luo.Liu@cixtech.com \
--to=luo.liu@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wuyi.shen@cixtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.