From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anton Kuchin <antonkuchin@nebius.com>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
NB-CoreTeam@nebius.com
Subject: Re: [PATCH 0/2] hw/acpi/aml-build: Fix free ranges calculation in crs_replace_with_free_ranges()
Date: Tue, 17 Nov 2026 07:21:02 -0500 [thread overview]
Message-ID: <20261117072016-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20261107-users-antonkuchin-to-send-fix-crs-replace-with-free-ranges-v1-0-0cede42456c4@nebius.com>
On Sat, Nov 07, 2026 at 12:59:47AM +0100, Anton Kuchin wrote:
> The assumption that all used ranges lie within the provided window
> bounds resulted in generation of free ranges beyond the limits and
> incorrect address assignment in guest. As used regions are collected
> without any knowledge about which limits will be applied later, some
> non-standard topologies with multiple expanders and devices break free
> ranges calculation. Skipping such used regions fixes the problem.
Could you be more specific please? Was an issue observed?
In which configurations? With which guests?
> While at this fix potential uint64 wrap around if range->limit is
> equal to UINT64_MAX that can add extra free range at the beginning
> of the address space. Not sure this can really happen with some
> combination of virtual topology and firmware version, but this
> check doesn't look expensive and it's better to handle it now than
> spend hours debugging this strange case later.
maybe but it should be documented better.
> Signed-off-by: Anton Kuchin <antonkuchin@nebius.com>
> ---
> Anton Kuchin (2):
> hw/acpi/aml-build: Ignore used ranges outside the requested window
> hw/acpi/aml-build: Avoid overflow when advancing the free_base cursor
>
> hw/acpi/aml-build.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
> ---
> base-commit: ddb42c53b4d91d12511f49ee4428d9594eb5eb49
> change-id: 20261106-users-antonkuchin-to-send-fix-crs-replace-with-free-ranges-761219313073
>
> Best regards,
> --
> Anton Kuchin <antonkuchin@nebius.com>
prev parent reply other threads:[~2026-11-17 12:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 23:59 [PATCH 0/2] hw/acpi/aml-build: Fix free ranges calculation in crs_replace_with_free_ranges() Anton Kuchin
2026-11-06 23:59 ` [PATCH 1/2] hw/acpi/aml-build: Ignore used ranges outside the requested window Anton Kuchin
2026-11-17 12:19 ` Michael S. Tsirkin
2026-11-17 12:28 ` Michael S. Tsirkin
2026-11-06 23:59 ` [PATCH 2/2] hw/acpi/aml-build: Avoid overflow when advancing the free_base cursor Anton Kuchin
2026-11-17 12:20 ` Michael S. Tsirkin
2026-11-17 12:21 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117072016-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=NB-CoreTeam@nebius.com \
--cc=anisinha@redhat.com \
--cc=antonkuchin@nebius.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.