All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@arm.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Johan Hovold <johan@kernel.org>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Saravana Kannan <saravanak@kernel.org>,
	Will Deacon <will@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Hanjun Guo <guohanjun@huawei.com>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Marc Zyngier <maz@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Sudeep Holla <sudeep.holla@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@arm.com>,
	James Clark <james.clark@linaro.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Al Grant <al.grant@arm.com>,
	"Johnny.Fan" <johnny.fan@cixtech.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	driver-core@lists.linux.dev, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/8] device property: Add firmware node IRQ affinity callbacks
Date: Tue, 17 Nov 2026 09:29:08 +0000	[thread overview]
Message-ID: <20261117092908.GU9176@e132581.arm.com> (raw)
In-Reply-To: <avwFYMdr7g4r6Z9y@ashevche-desk.local>

On Tue, Nov 17, 2026 at 09:42:24AM +0200, Andy Shevchenko wrote:
> On Mon, Nov 16, 2026 at 06:21:28PM +0000, Leo Yan wrote:
> > Platform IRQ affinity lookup currently selects the OF or ACPI helper
> > directly. Add fwnode_irq_get_affinity() and an irq_get_affinity operation
> > implemented by both firmware types.
> > 
> > Use the new helper for platform devices, preserving the existing fallback
> > to cpu_possible_mask when affinity information is unavailable.
> 
> From this commit message it's unclear why we do that. Is it any helpful in the
> future? If yes, for what?

This refactoring lets platform devices backed by swnode provide IRQ
affinity through the common fwnode interface. Patch 02 provides swnode's
IRQ affinity callback.

I will reply your comments in patch 02 for why we need swnode to
store IRQ affinity.

> ...
> 
> > static const struct cpumask *get_irq_affinity(struct platform_device *dev,
> 
> >  {
> >  	const struct cpumask *mask = NULL;
> >  #ifndef CONFIG_SPARC
> 
> > -	struct fwnode_handle *fwnode = dev_fwnode(&dev->dev);
> > -
> 
> Might be unneeded churn — you can leave these two lines being untouched.
> 
> > -	if (is_of_node(fwnode))
> > -		mask = of_irq_get_affinity(to_of_node(fwnode), num);
> > -	else if (is_acpi_device_node(fwnode))
> > -		mask = acpi_irq_get_affinity(ACPI_HANDLE_FWNODE(fwnode), num);
> 
> > +	mask = fwnode_irq_get_affinity(dev_fwnode(&dev->dev), num);
> 
> 	mask = fwnode_irq_get_affinity(fwnode, num);
> 
> >  #endif
> 
> >  	return mask ?: cpu_possible_mask;
> 
> But I understand the point as we have only a single user left. So I am not
> objecting the proposed approach, just pointed out on an alternative.

I'll keep the local fwnode variable as you suggest.

> ...
> 
> > +++ b/include/linux/fwnode.h
> 
> >  struct fwnode_operations;
> >  struct device;
> > +struct cpumask;
> 
> Yes, it's a bit disordered, can you place the new one before the 'device'
> to follow alphabetical order?

Will do.

Thanks,
Leo

  reply	other threads:[~2026-11-17  9:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 18:21 [PATCH 0/8] ACPI: arm64: Support PMU on Heterogeneous Systems Leo Yan
2026-11-16 18:21 ` [PATCH 1/8] device property: Add firmware node IRQ affinity callbacks Leo Yan
2026-11-16 18:28   ` sashiko-bot
2026-11-17  7:42   ` Andy Shevchenko
2026-11-17  9:29     ` Leo Yan [this message]
2026-11-16 18:21 ` [PATCH 2/8] device property: Add software-node IRQ affinity masks Leo Yan
2026-11-16 18:29   ` sashiko-bot
2026-11-17  7:50   ` Andy Shevchenko
2026-11-16 18:21 ` [PATCH 3/8] perf/arm_pmu: Register ACPI SPE and TRBE devices with software nodes Leo Yan
2026-11-16 18:38   ` sashiko-bot
2026-11-16 18:21 ` [PATCH 4/8] perf/arm_pmu: Prepare ACPI registration for per-CPU interrupts Leo Yan
2026-11-16 18:29   ` sashiko-bot
2026-11-16 18:21 ` [PATCH 5/8] perf/arm_pmu: Register ACPI CPU PMUs as platform devices Leo Yan
2026-11-16 18:44   ` sashiko-bot
2026-11-16 18:21 ` [PATCH 6/8] perf/arm_pmu: Support ACPI devices in the platform probe Leo Yan
2026-11-16 18:36   ` sashiko-bot
2026-11-16 18:21 ` [PATCH 7/8] perf/arm_pmu: Use ACPI CPU affinity in IRQ handling Leo Yan
2026-11-16 18:34   ` sashiko-bot
2026-11-16 18:21 ` [PATCH 8/8] ACPI: arm64: Move PMU device registration to drivers/acpi/arm64/ Leo Yan
2026-11-16 18:37   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117092908.GU9176@e132581.arm.com \
    --to=leo.yan@arm.com \
    --cc=al.grant@arm.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=anshuman.khandual@arm.com \
    --cc=brgl@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dakr@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djrscally@gmail.com \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=guohanjun@huawei.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=james.clark@linaro.org \
    --cc=jeremy.linton@arm.com \
    --cc=johan@kernel.org \
    --cc=johnny.fan@cixtech.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=mike.leach@arm.com \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=saravanak@kernel.org \
    --cc=sudeep.holla@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tglx@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.