From: Ido Schimmel <idosch@nvidia.com>
To: liamsmith827 <liamsmith827@grapheneos.org>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Liam Smith <liamsmith827@proton.me>
Subject: Re: [PATCH net-next v5 0/4] ipv4: restrict on-link fallback to lookup misses
Date: Tue, 17 Nov 2026 12:56:45 +0200 [thread overview]
Message-ID: <20261117105645.GA648376@shredder> (raw)
In-Reply-To: <20261116202741.13106-1-liamsmith827@grapheneos.org>
On Mon, Nov 16, 2026 at 08:27:37PM +0000, liamsmith827 wrote:
> From: Liam Smith <liamsmith827@proton.me>
>
> When an output interface is specified (e.g., using SO_BINDTODEVICE,
> IP_UNICAST_IF or IP_PKTINFO) and the FIB lookup fails, the IPv4 output
> path ignores the error and constructs an on-link route via the
> specified interface. According to the comment above the code, the
> intent was to allow sending packets via an interface that does not have
> any routes.
>
> However, the error code is not checked, so the fallback is also taken
> when the lookup hits an unreachable, blackhole or prohibit route/rule.
> In other words, these routes and rules are ignored when an output
> interface is specified [1].
>
> This is a problem for Android, which implements its VPN "kill switch"
> using prohibit rules, with the expectation that packets hitting such
> rules are never transmitted. Unprivileged applications can bind a
> socket to an interface and trivially bypass the VPN. This is especially
> bad on cellular interfaces where neighbor resolution is not needed, so
> packets can reach any destination and not only on-link ones.
>
> Solve this by only taking the fallback when the lookup did not match
> any route (i.e., a miss) and returning the error to the caller
> otherwise [2].
>
> It is currently impossible to distinguish between a miss and an
> unreachable rule since they both return the same error (-ENETUNREACH).
> Therefore, patch #1 adds a lookup flag that makes the lookup return a
> different error upon a miss and patch #2 uses it to restrict the
> fallback. Patch #3 adjusts the selftests and patch #4 updates the
> comment above the fallback.
>
> After the change, a packet that was previously transmitted on-link
> despite hitting one of these routes/rules is no longer transmitted and
> an error is returned to user space instead. It is unlikely that anyone
> is relying on the current behavior:
>
> 1. It is a side effect of not checking the error code and it contradicts
> ip-route(8) and ip-rule(8), which document these routes and rules as
> dropping packets or generating an error.
>
> 2. These routes and rules are already honored when the output interface
> is a VRF device or enslaved to one.
>
> 3. These rules are already honored by IPv6, which does not have such a
> fallback.
>
> The following is unchanged:
>
> 1. Packets can still be sent via the specified interface when the
> lookup does not match any route, which is the original use case.
>
> 2. The fallback is still always taken for multicast packets. The
> precedent in ip_route_output_key_hash_rcu() is to not enforce
> restriction rule/routes on oif-bound multicast, so that precedent should
> be followed here too.
I think this series can be merged. It does change user-visible behavior,
but the regression risk seems to be low. Any configuration broken by
this change most likely doesn't work with VRFs / IPv6. If regressions
are reported, we can look into allowing the fallback for specific error
codes.
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
prev parent reply other threads:[~2026-11-17 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 20:27 [PATCH net-next v5 0/4] ipv4: restrict on-link fallback to lookup misses liamsmith827
2026-11-16 20:27 ` [PATCH net-next v5 1/4] ipv4: add FIB_LOOKUP_REPORT_MISS liamsmith827
2026-11-16 20:27 ` [PATCH net-next v5 2/4] ipv4: restrict on-link fallback to lookup misses liamsmith827
2026-11-16 20:27 ` [PATCH net-next v5 3/4] selftests: net: test restricted on-link fallback liamsmith827
2026-11-16 20:27 ` [PATCH net-next v5 4/4] ipv4: replace obsolete routing comment liamsmith827
2026-11-17 10:56 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117105645.GA648376@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=liamsmith827@grapheneos.org \
--cc=liamsmith827@proton.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.