From: ecordonnier@snap.com
To: openembedded-core@lists.openembedded.org
Cc: Etienne Cordonnier <ecordonnier@snap.com>
Subject: [PATCH v3 3/3] archiver.bbclass: fail on sources which cannot be archived
Date: Tue, 17 Nov 2026 13:24:57 +0100 [thread overview]
Message-ID: <20261117122457.435864-4-ecordonnier@snap.com> (raw)
In-Reply-To: <20261117122457.435864-1-ecordonnier@snap.com>
From: Etienne Cordonnier <ecordonnier@snap.com>
In the original mode, do_ar_original archives a source if the fetcher's
localpath is a file, or a directory. Any other source is silently skipped,
and the source archive is incomplete without any notice. This used to happen
for shallow git fetches without a clone, which is fixed by commit
"archiver.bbclass: archive shallow git sources which have no clone".
No fetcher has a valid case for a localpath which is neither a file nor a
directory after do_fetch, so make it a fatal error.
AI-Generated: Claude Opus 5.5
Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
---
meta/classes/archiver.bbclass | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass
index d22213be33..a54882eeb8 100644
--- a/meta/classes/archiver.bbclass
+++ b/meta/classes/archiver.bbclass
@@ -248,6 +248,8 @@ python do_ar_original() {
bb.fatal("Cannot determine archive names for original source because 'name=' URL parameter '%s' is used twice. Make it unique in: %s %s" % (name, tarball_suffix[name], url))
tarball_suffix[name] = url
create_tarball(d, tmpdir + '/.', name, ar_outdir)
+ else:
+ bb.fatal("Cannot archive %s: its local path %s is neither a file nor a directory" % (url, local))
# Emit patch series files for 'original'
bb.note('Writing patch series files...')
--
2.43.0
prev parent reply other threads:[~2026-11-17 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 12:24 [PATCH v3 0/3] archiver.bbclass: archive shallow git sources which have no clone ecordonnier
2026-11-17 12:24 ` [PATCH v3 1/3] " ecordonnier
2026-11-20 13:30 ` Paul Barker
2026-11-17 12:24 ` [PATCH v3 2/3] archiver.bbclass: remove .git from original git source archives ecordonnier
2026-11-17 12:24 ` ecordonnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117122457.435864-4-ecordonnier@snap.com \
--to=ecordonnier@snap.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.