From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.219.44 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794920411; b=S77W54F2BTenJYLfiGmD3gi/aNzyfOjzldp9bDAtUpQkN0LJQWiN1qV+0DA/S13gMFRa 2vPKsLouR5q0b6ayHxkpt4agEAY6TixbAAi1V2u6ufXbt+t+5K2lot/PCSFYWM5GspBxm MYvFymLWsYM/LXSmFWTPOn1pPEd7Txc4t5x7VEbSTMCd/cihVqg6IwtEg5s71ebSEfEO7 J9aSJXDl3rA9cX/rE/wnHJ0nmLEQ8tVFSzWg8gjkdOuF3D2nJg8dqYu5apaJD012ArutA 9U4GIxZd+4G6FNiVxTigONODypO+O8EzG2mQVAwu41FKn0OhxSFzpMRwoABZF1JKpEg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794920411; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=QHFqCnsPAP40ABSi/lHx2qUxkasVh8VfNqtA5qQ6pG8=; b=psC3kGFlvJrV776baa3rCtf6JS6AeAXJvkD2ZQrm3T/+VdQljhszid7bx4BlPd87Y4EO 3q+6z6egipenaqhidQzFqmv5ysPIH/vEo6gBUFXZRHKCdlOGMkaVk6Ozv7FvBrcPtAVto m8PAKepgGQLpS4dcu7SUAo5hlxq/3DPdsRZvyLynpCs0Oc9/PhUvkf5HVcIlRXTgzj1kn ucJxNNrIv5kzeuizDDAgQqWgvaUWh8neKBS3Bi6s9re48QugkjynGYve95Z7wQKkYqiU6 seInBPYqdQtDWRZVyCOv7YisTuz/Bb6iyNENPwVIdTnFRucQOfN+eTHSWpABfyLgHfg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=b2YFLXbH; arc=none smtp.remote-ip=209.85.219.44 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECB36606A8AF for ; Tue, 17 Nov 2026 13:00:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org ECB36606A8AF Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=b2YFLXbH Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-91f11161831so29933946d6.1 for ; Tue, 17 Nov 2026 05:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1794920409; x=1795525209; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QHFqCnsPAP40ABSi/lHx2qUxkasVh8VfNqtA5qQ6pG8=; b=b2YFLXbHZxblEetdGwqZ5iSDT1YoFcKjYGOKJJy5u7qsJIBbCx0MYywsMpj2imTpMw hB+ccsrh32tsGLPP4+qmvZSvgjHVKXuiP2gQeazDwsNFsq/appf1u8J5OMFpYk/XkZxd z3x4mPDl1zEz4j2aUMwofcSPp3am92+F+rnQoWwEjGu8Ms6rXu+p+xS/EUcrKbeqeGWJ RC9tTzCbyFPBRWUoTc4tR5v1CtXD4X1F5mAlRxaktF7GWeVrkiCykYoJP5KRwoHohffO mfBRhIkTNEOYR8tsmFla40vh/B1swzaJXT0u6LallXDgkhg4KC/GXTj17m0CCM1odHDD WWQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794920409; x=1795525209; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QHFqCnsPAP40ABSi/lHx2qUxkasVh8VfNqtA5qQ6pG8=; b=dwvT9kCkthlR+jXCq/lZsIu42yGan8HDG5CYdfu10OBT3utfuQFpyD12ZS5b1wyKsg dx7G5yVRnpBb/A9wB347ZSrsYFPDc2lrG4f1rwbwDGyHvwz3h0OTR0eJwRr1o9pF4BWP GgzXiV4P0yQX2L0b42dAiZr+kN5RbPm4UxQJMetloYIwNXrkX4AGfkG1uSRC03kvTO4j OdGnBl/jPcDHxIgFKd6W05tRLAkXl9yDJfz67z15ITRVMJEXjSMR0MWqaBTvhPqqnJJr +l9N37ZIQeRkjVqRKSWQmWNhDL8jNy6pnVPchL8ix+BMUO8I1Hb8YuaDhU1Sa6oALoLH G6YA== X-Forwarded-Encrypted: i=1; AL+hErHzciw1Ci+mJqse9ky+ROjhcabCE3BpYgQNy0H7Jb4LH1rURjoSL1KWDWRqBo/3KMltxLfmmg==@lists.linux.dev X-Gm-Message-State: APuU4Z/kFUty7SxCCsr4Wi+liMabhY3ExCbqgCSslOfQVtgpPWAQAcog FwpTsypk35+IDQZuYvYKMQ/SWANYj7qpzl6SmrUYM6MfIjkHY0jDfY1B66gm3jb71Ds= X-Gm-Gg: AYBFou3gDFJSRPE1nLRT9UiZu7YS2GuiL8uHhxi2OeixVwtvIMFXm7aFVa0gznTAh7f 8JFrhAvdtsBxHvgPI2UF7KF5FpwrhwcI4gLwmNdt7yQ2RZttVTD4T0YY0eXZlhiYQfOHZsCt5cH QsulZ5Eo5KZtSpvfSjg/MDhJnIylxh0Tytm+wwOYeP31nLkYBj9aMV6oqVNd8n3a6tgi9oSr0rD oyQmYCgAUOUtx+j+HXT7/GKSQy9Np4pSnMCnN6y5WtJbDqQTfy0g5LJ6gCTWr/8p5jR/+HFwLfl KOzC1rhyEfxyKTQRfH2W01wdfFqIm9+iKuowMDbJtYYzRLXSHHDvhVP28tOLx/MUQNgwqPzTsq2 eBDvqTHkWsKW7wmzyuRKIInbiTNEUdbFwrtEk1yXVAjmLsSQ7scHPtRxiKvkdBmhlTtI5kctjdl qp09w7vxbP6zaqt0Ul5IxxpcYKrXhLPEnRhU2nKia+DUOhjNPf9f6lA1OxFLyjLq0X366ARdQGf nDzqPERZQ/jQcQ6lIVcTspdaVKwiExjduJLgIGsYP0mpg8lYgqcoVQD7uWEAKxudVXjSuZsNq90 m7VGg2ud0lAyBh9IsrXjBFMlDfg= X-Received: by 2002:a05:620a:a208:b0:949:5c62:e775 with SMTP id af79cd13be357-9495c62ea7emr1501690585a.15.1794920408653; Tue, 17 Nov 2026 05:00:08 -0800 (PST) Received: from ziepe.ca ([142.166.156.71]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9494c803abbsm1067907885a.7.2026.11.17.05.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 05:00:07 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xTIn7-0000000CJGS-3fNi; Tue, 17 Nov 2026 09:00:05 -0400 Date: Tue, 17 Nov 2026 09:00:05 -0400 From: Jason Gunthorpe To: Peng Fan Cc: "Peng Fan (OSS)" , Frank Li , Vinod Koul , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Laxman Dewangan , Jon Hunter , Thierry Reding , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Larisa IIeana Grigore , imx@lists.linux.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan Subject: Re: [PATCH v6 0/9] dmaengine: add DMA channel bus and fsl-edma per-channel IOMMU support Message-ID: <20261117130005.GC2606445@ziepe.ca> References: <20261112-edma-iommu-v3-v6-0-b038edb8ce6f@nxp.com> <20261116193021.GB2452510@ziepe.ca> X-Mailing-List: iommu@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Nov 17, 2026 at 04:30:15PM +0800, Peng Fan wrote: > On Mon, Nov 16, 2026 at 03:30:21PM -0400, Jason Gunthorpe wrote: > >On Thu, Nov 12, 2026 at 03:53:03PM +0800, Peng Fan (OSS) wrote: > >> I used iommu-map for eDMA, but iommu experts rejected it: > >> "Using iommu-map to describe synthetic dma_chan_dev devices that the > >> kernel creates is the same kind of DT abuse from over here:" > >> More info: https://lore.kernel.org/all/20260917144804.GI3196566@ziepe.ca/ > >> > >> So I followed here [2] as Krzysztof wrote for QCOM VPU: > >> "Thanks Jason for context and detailed arguments. Robin did not chime in > >> yet, but from what I understood the DT-child-node approach will be the > >> way we should go here. > >> > >> I accept above point of view and I am fine with this, thus Vishnu and > >> Vikash - please go ahead with DT-child-node solution we had some time ago." > >> [2] https://lore.kernel.org/linux-iommu/c7b956a9-d3e8-4e18-b780-5d08f5cd2ca1@kernel.org/ > >> > >> This series adds per-channel DT child node support to fsl-edma and, as a > >> prerequisite, introduces a proper bus for DMA channel devices. > > > >To be fair this is discouraged too, now that I've seen 3-4 people > >trying to do exactly the same thing I'm not as positive about the > >DT-child-node hack. > > I may not describe it clear in cover-letter. > > I understand the concern. Let me explain why I believe it is justified here > rather than a hack. > > On i.MX eDMA each channel has its own interrupt, its own register region, > and on i.MX8QM even its own power domain. Each channel may also have its > own Stream ID, or share one when SIDs are scarce. These are genuine > per-channel hardware resources, not software fiction. > > In dmaengine each channel is already modeled as a channel device (see > dmaengine_chan_dev()), and this series puts those devices on a real bus > (dmaengine_chan_bus_type) as a prerequisite. The DT child node simply > describes that existing device, so its reg/interrupts/power-domains/iommus > are attached per channel instead of as index-matched flat lists on the > controller. If they are real devices then why can't they come out as platform devices? I think you are overstating how independent they are. Many single devices have per "channel" resources like MMIO and IRQs. That's totally normal. It doesn't make the sub resources independent devices. AFAICT what you have here is some HW designer used SID where they should have used SSID and you are trying to hack DT to make that usable because Linux does not support a SID as SSID model today. Again, since this is the 3rd - 4th case like this, it seems like a popular hardware choice and we should try to do better to make Linux support if we can. Jason