From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] eal: silence unreachable code warning
Date: Tue, 17 Nov 2026 13:04:27 -0800 [thread overview]
Message-ID: <20261117130427.36f2c01d@phoenix.local> (raw)
In-Reply-To: <avyoOHd2QAf6aoo7@bricha3-mobl1.ger.corp.intel.com>
On Tue, 17 Nov 2026 19:17:12 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:
> On Tue, Nov 17, 2026 at 09:40:59AM -0800, Stephen Hemminger wrote:
> > Clang evalutes strlen of constant string at compile time, then
> > complains about unreachable code. Use extra parenthesis to
> > mark code as explcitly dead.
> >
> > Bugzilla ID: 2135
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > lib/eal/common/rte_version.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/eal/common/rte_version.c b/lib/eal/common/rte_version.c
> > index 627b89d4a8..62572428fc 100644
> > --- a/lib/eal/common/rte_version.c
> > +++ b/lib/eal/common/rte_version.c
> > @@ -36,7 +36,9 @@ rte_version(void)
> > static char version[32];
> > if (version[0] != 0)
> > return version;
> > - if (strlen(RTE_VER_SUFFIX) == 0)
> > +
> > + /* extra paren to silence unreachable warnings */
> > + if ((strlen(RTE_VER_SUFFIX) == 0))
> > snprintf(version, sizeof(version), "%s %d.%02d.%d",
> > RTE_VER_PREFIX,
> > RTE_VER_YEAR,
> > --
>
> Is it guaranteed that the checker won't look inside the double brackets? An
> alternative suggestion is to change RTE_VER_SUFFIX to the function call to
> the (public) API rte_version_suffix() and use strlen on that. We can even
> mark the function as __rte_noinline to avoid optimizer getting rid of the
> call in future and reintroducing the warning.
>
> Also, when fixing this, I think it would be nice to also fix the indent of
> the else leg.
>
> /Bruce
Clang suggests it as a fix so I think that should always work.
Gcc unreachable flag is a noop, the compiler structure makes it too
hard for them to do the analysis.
Ok, can fix the indent as well.
prev parent reply other threads:[~2026-11-17 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 17:40 [PATCH] eal: silence unreachable code warning Stephen Hemminger
2026-11-17 19:17 ` Bruce Richardson
2026-11-17 21:04 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117130427.36f2c01d@phoenix.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.