All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Joe Damato <joe@dama.to>, Dmitry Antipov <dmantipov@yandex.ru>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	bridge@lists.linux.dev, netdev@vger.kernel.org
Subject: Re: [PATCH] net: bridge: avoid redundant strlen() in show_backup_port()
Date: Tue, 17 Nov 2026 19:56:48 +0200	[thread overview]
Message-ID: <20261117175648.GA961425@shredder> (raw)
In-Reply-To: <avyTnnR3xnUSnPmU@devvm20253.cco0.facebook.com>

On Tue, Nov 17, 2026 at 09:49:18AM -0800, Joe Damato wrote:
> On Tue, Nov 17, 2026 at 07:51:06PM +0300, Dmitry Antipov wrote:
> > In store_backup_port(), prefer strchrnul() over strchr() to
> > avoid redundant call to strlen().
> 
> a couple things:
> 
> - i dont't think the change is worth it because it feels like unnecessary
>   churn in a path that isn't a hot path. how many bytes are we really avoiding
>   counting here?
> 
> - commit message mentions store_backup_port but subject line says
>   show_backup_port, so commit would need to be respun
> 
> but imho i think this should be dropped

Yep.

pw-bot: rejected

      reply	other threads:[~2026-11-17 17:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 16:51 [PATCH] net: bridge: avoid redundant strlen() in show_backup_port() Dmitry Antipov
2026-11-17 17:49 ` Joe Damato
2026-11-17 17:56   ` Ido Schimmel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117175648.GA961425@shredder \
    --to=idosch@nvidia.com \
    --cc=bridge@lists.linux.dev \
    --cc=dmantipov@yandex.ru \
    --cc=joe@dama.to \
    --cc=netdev@vger.kernel.org \
    --cc=razor@blackwall.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.