All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH] KVM: SEV: never retry after #NPF on paging structures
Date: Tue, 17 Nov 2026 15:07:26 -0500	[thread overview]
Message-ID: <20261117200726.2421132-1-sashal@kernel.org> (raw)
In-Reply-To: <20261117185922.466255-1-pbonzini@redhat.com>

On Tue, Nov 17, 2026 at 07:59:22PM +0100, Paolo Bonzini wrote:
> +	error_code = svm->vmcb->control.exit_info_1;
> +	if (error_code & PFERR_GUEST_PAGE_MASK)
> +		goto resume_guest;

The subject says "never retry", but resume_guest returns
X86EMUL_RETRY_INSTR, so this does retry: the guest is resumed and the
instruction runs again.

In your reply to my patch you had X86EMUL_UNHANDLEABLE here instead:

  https://lore.kernel.org/r/7b4beea2-2bc9-44d8-be6a-ecfe678091dc@redhat.com

Which one did you mean? If it's the retry, the subject probably wants to
say "never emulate".

-- 
Thanks,
Sasha

      parent reply	other threads:[~2026-11-17 20:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 18:59 [PATCH] KVM: SEV: never retry after #NPF on paging structures Paolo Bonzini
2026-11-17 19:28 ` sashiko-bot
2026-11-17 20:07 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117200726.2421132-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.