From: Conor Dooley <conor@kernel.org>
To: Mason Huo <mason.huo@starfivetech.com>
Cc: Corey Minyard <corey@minyard.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
openipmi-developer@lists.sourceforge.net
Subject: Re: [PATCH vV 1/2] dt-bindings: ipmi: Convert starfive,kcs-bmc to DT schema
Date: Wed, 18 Nov 2026 17:57:46 +0000 [thread overview]
Message-ID: <20261118-repackage-backlight-1bdc5955a8d2@spud> (raw)
In-Reply-To: <20261118062526.1436893-2-mason.huo@starfivetech.com>
[-- Attachment #1: Type: text/plain, Size: 2454 bytes --]
On Wed, Nov 18, 2026 at 02:25:25PM +0800, Mason Huo wrote:
> Convert the starfive,kcs-bmc binding to DT schema format.
This is not a conversion since you are not deleting anything?
>
> Signed-off-by: Mason Huo <mason.huo@starfivetech.com>
> ---
> .../bindings/ipmi/starfive,kcs-bmc.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml
>
> diff --git a/Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml
> new file mode 100644
> index 000000000000..2cb91d321a32
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ipmi/starfive,kcs-bmc.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ipmi/starfive,kcs-bmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive BMC KCS Devices
> +
> +maintainers:
> + - Mason Huo <mason.huo@starfivetech.com>
> +
> +description:
> + The StarFive BMC SoCs use Keyboard-Controller-Style (KCS) interfaces on
> + the eSPI bus for in-band IPMI communication with their host. The KCS
> + channels are part of a Super I/O (SIO) block and each channel occupies a
> + 0x100 byte register window, starting at offset 0x200 of the SIO register
> + space. A channel is identified by its register offset and the
> + "starfive,sio-id" of the parent SIO node.
Where is the binding for the parent SIO node? Hard to review this
without that I think.
> +
> +properties:
> + compatible:
> + enum:
> + - starfive,jhb100-kcs-bmc
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: KCS channel interrupt
> + - description: eSPI bus reset de-assertion interrupt
> +
> + interrupt-names:
> + items:
> + - const: kcs
> + - const: espi_rst
No need to have "rst" since this is a reset by nature ;)
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + kcs@200 {
s/kcs/ipmi/?
> + compatible = "starfive,jhb100-kcs-bmc";
> + reg = <0x200 0x100>;
> + interrupts = <282>, <57>;
> + interrupt-names = "kcs", "espi_rst";
> + };
> --
> 2.50.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-11-18 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 6:25 [PATCH 0/2] ipmi: Add StarFive JHB100 KCS BMC driver Mason Huo
2026-11-18 6:25 ` [PATCH vV 1/2] dt-bindings: ipmi: Convert starfive,kcs-bmc to DT schema Mason Huo
2026-11-18 6:36 ` sashiko-bot
2026-11-18 17:57 ` Conor Dooley [this message]
2026-11-18 6:25 ` [PATCH vV 2/2] ipmi: add StarFive KCS BMC driver Mason Huo
2026-11-18 14:00 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118-repackage-backlight-1bdc5955a8d2@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corey@minyard.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mason.huo@starfivetech.com \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.