From: Vipin Sharma <vipinsh@google.com>
To: Samiullah Khawaja <skhawaja@google.com>
Cc: Alex Williamson <alex.williamson@nvidia.com>,
kvm <kvm@vger.kernel.org>, Alex Williamson <alex@shazbot.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Bjorn Helgaas <bhelgaas@google.com>,
Kevin Tian <kevin.tian@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
praan@google.com
Subject: Re: [RFC PATCH 0/5] PCI/vfio-pci: Guard resets against active SR-IOV VFs
Date: Tue, 17 Nov 2026 16:06:23 -0800 [thread overview]
Message-ID: <20261118000511.GC2250529.vipinsh@google.com> (raw)
In-Reply-To: <avzfBjBZiOnJUH4W@google.com>
On Tue, Nov 17, 2026 at 11:31:08PM +0000, Samiullah Khawaja wrote:
> On Tue, Nov 17, 2026 at 03:02:00PM -0800, Vipin Sharma wrote:
> > On Thu, Aug 13, 2026 at 10:30:45PM +0000, Samiullah Khawaja wrote:
> > > On Tue, Aug 11, 2026 at 10:53:18PM -0600, Alex Williamson wrote:
> > > > It's recently been found[1] that vfio-pci doesn't restrict resets on PFs
> > > > while SR-IOV is enabled. This can not only result in an uncoordinated
> > > > disruption of the use of the associated VFs, but the ongoing use of and
> > > > access to the VF has the potential to result in machine checks.
> > > >
> > > > This series proposes that this gap is largely an oversight of
> > > > pci_reset_function() to recognize that a PF reset affecting SR-IOV VFs
> > > > violates the scope boundary of the pci_reset_function() API.
> > >
> > > Hi Alex,
> > >
> > > Thanks for sending out the RFC to fix this issue. I cherry-picked it
> > > into my environment to verify that whether it fixes the issue I was
> > > experiencing and it does fix it. I will continue to do more testing, but
> > > when you send this as a formal v1, you can add:
> > >
> > > Tested-by: Samiullah Khawaja <skhawaja@google.com>
> > > Reported-by: Samiullah Khawaja <skhawaja@google.com>
> > >
> >
> > Hi Alex,
> >
> > Is this series still on your radar for formal v1?
> >
> > If this is the direction we are going in I can use it for liveupdate work
> > https://lore.kernel.org/all/auzftbPFO_6XBYVw%40google.com/
> >
> > Thanks
> > Vipin
>
> Hi Vipin,
>
> Alex asked me whether I or someone on our team could pick up this
> series. Pranjal is working on it and will send out a new version. There
> is some extra work needed on the IOMMU side to make sure that the device
> is moved to a blocking domain when the reset is skipped.
>
> But I think the patch you need is fairly independent and can be sent out
> separately from this series:
> https://lore.kernel.org/kvm/20260812045325.2733631-6-alex.williamson@nvidia.com/
>
That works for me. I can send this patch separately.
Thanks,
Vipin
prev parent reply other threads:[~2026-11-18 0:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 4:53 [RFC PATCH 0/5] PCI/vfio-pci: Guard resets against active SR-IOV VFs Alex Williamson
2026-08-12 4:53 ` [RFC PATCH 1/5] PCI: Refuse function reset of an SR-IOV PF with enabled VFs Alex Williamson
2026-08-12 5:01 ` sashiko-bot
2026-08-13 23:22 ` Samiullah Khawaja
2026-08-14 14:37 ` Alex Williamson
2026-08-14 15:54 ` Samiullah Khawaja
2026-08-17 12:18 ` Jason Gunthorpe
2026-08-18 7:07 ` Tian, Kevin
2026-08-18 14:03 ` Jason Gunthorpe
2026-08-18 20:39 ` Alex Williamson
2026-08-20 22:38 ` Samiullah Khawaja
2026-08-20 23:37 ` Jason Gunthorpe
2026-08-21 2:20 ` Samiullah Khawaja
2026-09-04 19:06 ` Jason Gunthorpe
2026-08-27 5:35 ` Tian, Kevin
2026-09-22 1:47 ` Samiullah Khawaja
2026-08-25 23:55 ` Samiullah Khawaja
2026-08-12 4:53 ` [RFC PATCH 2/5] PCI: Add pci_reset_bus_cond() for a caller-gated slot or bus reset Alex Williamson
2026-08-12 5:00 ` sashiko-bot
2026-08-12 4:53 ` [RFC PATCH 3/5] vfio/pci: Refuse to reset an SR-IOV PF with enabled VFs Alex Williamson
2026-08-12 5:02 ` sashiko-bot
2026-08-12 4:53 ` [RFC PATCH 4/5] PCI: Export pci_reset_supported() Alex Williamson
2026-08-12 4:59 ` sashiko-bot
2026-08-12 4:53 ` [RFC PATCH 5/5] vfio/pci: Use pci_reset_supported() in place of reset_works Alex Williamson
2026-08-12 4:59 ` sashiko-bot
2026-08-12 21:45 ` [RFC PATCH 0/5] PCI/vfio-pci: Guard resets against active SR-IOV VFs Bjorn Helgaas
2026-08-12 22:53 ` Alex Williamson
2026-08-17 20:23 ` Tony Nguyen
2026-08-13 22:30 ` Samiullah Khawaja
2026-11-17 23:02 ` Vipin Sharma
2026-11-17 23:31 ` Samiullah Khawaja
2026-11-18 0:06 ` Vipin Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118000511.GC2250529.vipinsh@google.com \
--to=vipinsh@google.com \
--cc=alex.williamson@nvidia.com \
--cc=alex@shazbot.org \
--cc=bhelgaas@google.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=praan@google.com \
--cc=skhawaja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.