From: Rosen Penev <rosenp@gmail.com>
To: "Stuart Hayes" <stuart.w.hayes@gmail.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Doug Warzecha" <Douglas_Warzecha@dell.com>,
"Andrew Morton" <akpm@osdl.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org
Subject: [PATCH v3 2/4] platform/x86: dell: dcdbas: Suppress bind attributes of the platform driver
Date: Tue, 17 Nov 2026 19:56:36 -0800 [thread overview]
Message-ID: <20261118035638.11773-3-rosenp@gmail.com> (raw)
In-Reply-To: <20261118035638.11773-1-rosenp@gmail.com>
The dcdbas platform device is created by the module itself and stays
in use for as long as the module is loaded: dell-smbios-smm allocates
its SMI buffers against it through dcdbas_smi_alloc() whether or not
the driver is bound.
Binding the driver again after an unbind also leaks state:
dcdbas_check_wsmt() runs a second time and memremap()s the firmware
SMI buffer again, overwriting bios_buffer and leaking the previous
mapping.
Unbinding or rebinding the device by hand is not useful, so hide the
bind and unbind files.
Fixes: 12c956c4f32e ("firmware: dcdbas: Add support for WSMT ACPI table")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/platform/x86/dell/dcdbas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c
index f5d214b7bb6c..6bab3e0619bc 100644
--- a/drivers/platform/x86/dell/dcdbas.c
+++ b/drivers/platform/x86/dell/dcdbas.c
@@ -706,6 +706,7 @@ static void dcdbas_remove(struct platform_device *dev)
static struct platform_driver dcdbas_driver = {
.driver = {
.name = DRIVER_NAME,
+ .suppress_bind_attrs = true,
},
.probe = dcdbas_probe,
.remove = dcdbas_remove,
--
2.56.1
next prev parent reply other threads:[~2026-11-18 3:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 3:56 [PATCH v3 0/4] platform/x86: dell: dcdbas: Fix SMI completion wait and buffer handling Rosen Penev
2026-11-18 3:56 ` [PATCH v3 1/4] platform/x86: dell: dcdbas: Actually wait for the host control SMI Rosen Penev
2026-11-19 20:34 ` Andy Shevchenko
2026-11-18 3:56 ` Rosen Penev [this message]
2026-11-19 20:34 ` [PATCH v3 2/4] platform/x86: dell: dcdbas: Suppress bind attributes of the platform driver Andy Shevchenko
2026-11-18 3:56 ` [PATCH v3 3/4] platform/x86: dell: dcdbas: Release the SMI buffer in remove Rosen Penev
2026-11-20 9:37 ` Ilpo Järvinen
2026-11-18 3:56 ` [PATCH v3 4/4] platform/x86: dell: dcdbas: Validate the WSMT buffer description Rosen Penev
2026-11-19 20:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118035638.11773-3-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=Douglas_Warzecha@dell.com \
--cc=akpm@osdl.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.