All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rosen Penev <rosenp@gmail.com>
To: "Pali Rohár" <pali@kernel.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Arnd Bergmann" <arnd@arndb.de>
Cc: linux-hwmon@vger.kernel.org
Subject: [PATCH v2] hwmon: (dell-smm) Reject out-of-range pwm values
Date: Tue, 17 Nov 2026 20:04:17 -0800	[thread overview]
Message-ID: <20261118040417.19049-1-rosenp@gmail.com> (raw)

dell_smm_write() scales the value written to pwmN with

	DIV_ROUND_CLOSEST(val, data->i8k_pwm_mult)

before clamping the result to the valid fan states. The rounding adds
i8k_pwm_mult / 2 to val first, which overflows for values near
LONG_MAX and wraps to a large negative number. That is then clamped to
0, so writing a huge value turns the fan off instead of running it at
the highest speed. With the default fan_max of 2, writing any value
from LONG_MAX - 63 up to LONG_MAX selects fan state 0.

The pwm range is well defined, so return -EINVAL for values outside
0 to 255, as is the convention for pwm attributes.

Fixes: e7f5f275c62a ("i8k: Implement hwmon based fan speed control")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
Changes in v2:
- Return -EINVAL for values outside 0 to 255 instead of clamping them.
- Patch 2 of v1 was applied, so this is sent alone.
- v1: https://lore.kernel.org/linux-hwmon/3c36959a51788bbc5d08f364fe7d922b5c4d4d87.1794633179.git.rosenp@gmail.com/

Developed with the help of an AI coding assistant (Claude Opus 5.5),
as described in the v1 cover letter. I reviewed the change and I am
responsible for it.

Compile-tested only (W=1). The test machine's BIOS ignores manual pwm
writes, so the change could not be observed at runtime.

 drivers/hwmon/dell-smm-hwmon.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 798d2fe9d8b2..301ce2bed6a6 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1022,6 +1022,9 @@ static int dell_smm_write(struct device *dev, enum hwmon_sensor_types type, u32
 	case hwmon_pwm:
 		switch (attr) {
 		case hwmon_pwm_input:
+			if (val < 0 || val > 255)
+				return -EINVAL;
+
 			pwm = clamp_val(DIV_ROUND_CLOSEST(val, data->i8k_pwm_mult), 0,
 					data->i8k_fan_max);
 

base-commit: 09560558c9eabd4e85b68a97fcd102f1186b4790
-- 
2.56.1


             reply	other threads:[~2026-11-18  4:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  4:04 Rosen Penev [this message]
2026-11-18  4:08 ` [PATCH v2] hwmon: (dell-smm) Reject out-of-range pwm values sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118040417.19049-1-rosenp@gmail.com \
    --to=rosenp@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=pali@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.