From: linuxtestproject.agent@gmail.com
To: Wake Liu <wakel@google.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] sys_rtc01: Report TCONF on system time mismatch when STA_UNSYNC is set
Date: Wed, 18 Nov 2026 04:49:14 +0000 [thread overview]
Message-ID: <20261118044914.3815-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20261117235848.2975548-1-wakel@google.com>
Hi Wake,
On Tue, Nov 17, 2026, Wake Liu <wakel@google.com> wrote:
> sys_rtc01: Report TCONF on system time mismatch when STA_UNSYNC is set
> + } else if (is_clock_unsynced()) {
> + tst_res(TCONF,
> + "%s: since_epoch (%lld), system time (%lld), diff %llds > slack %lds (STA_UNSYNC is set)",
> + name, (long long)since_epoch, (long long)sys_epoch,
> + diff, slack);
STA_UNSYNC is already set at boot by ntp_init() and rtc_hctosys() (via
do_settimeofday64() -> ntp_clear()), and it is only ever cleared when a
userspace NTP daemon calls adjtimex(2) with ADJ_STATUS. On any system without
an active NTP daemon, is_clock_unsynced() always returns 1 even if the clock
was never stepped after boot, making the TFAIL branch unreachable and masking
real RTC vs system time mismatches. Conversely, when an NTP daemon is active
and clears STA_UNSYNC after syncing a system booted with a wrong RTC, the RTC
can still diverge if CONFIG_RTC_SYSTOHC is disabled or unsupported by the
driver.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-11-18 4:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 23:58 [LTP] [PATCH] sys_rtc01: Report TCONF on system time mismatch when STA_UNSYNC is set Wake Liu via ltp
2026-11-18 4:49 ` linuxtestproject.agent [this message]
2026-11-18 9:23 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118044914.3815-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=wakel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.