All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sailesh-003 <saileshnandanavanam@gmail.com>
To: sj@kernel.org
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Sailesh Nandanavanam <saileshnandanavanam@gmail.com>
Subject: Re: [PATCH 2/2] mm/damon/tests/core-kunit: add test for damon_call() with repeat control
Date: Wed, 18 Nov 2026 11:32:06 +0530	[thread overview]
Message-ID: <20261118060206.29439-1-saileshnandanavanam@gmail.com> (raw)
In-Reply-To: <20261118014632.95656-1-sj@kernel.org>

From: Sailesh Nandanavanam <saileshnandanavanam@gmail.com>

On Wed, 18 Nov 2026 SJ Park <sj@kernel.org> wrote:

> I think the above last two expects are somewhat too much implementation detail.
> I don't think we are promising those list status.  I'd prefer dropping those.

Agreed, dropping both list assertions.

> Can anything leak or corrupted if we don't call list_del() here?

No.  The control is stack-allocated and damon_destroy_ctx() does not
touch call_controls, so nothing is leaked or accessed afterwards.  Will
drop the list_del().

> Could we merge the above two tests into one, say, damon_test_call()?

Will merge them into damon_test_call() and send v2 as a single patch.

> Apparently this patch was meant to be sent as a part of a series with another
> patch [1] but individually sent by a setup failure.  As a result, this patch is
> not reviewed by Sashiko.  Could you please repost as the series?

Sorry for the mess.  Since the two tests will be merged, v2 will be a
single patch, so Sashiko will review it.


Thanks,
Sailesh

      reply	other threads:[~2026-11-18  6:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 17:48 [PATCH 2/2] mm/damon/tests/core-kunit: add test for damon_call() with repeat control Sailesh Nandanavanam
2026-11-18  1:46 ` SJ Park
2026-11-18  6:02   ` Sailesh-003 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118060206.29439-1-saileshnandanavanam@gmail.com \
    --to=saileshnandanavanam@gmail.com \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.