All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yu, Fei" <fei.yu@intel.com>
To: tvrtko.ursulin@igalia.com
Cc: dri-devel@lists.freedesktop.org, kernel-dev@igalia.com,
	mcanal@igalia.com, christian.koenig@amd.com, fei.yu@intel.com
Subject: Re: [PATCH 0/3] drm/syncobj: Allocation avoiding fast path
Date: Wed, 18 Nov 2026 16:06:11 +0800	[thread overview]
Message-ID: <20261118080611.180520-1-fei.yu@intel.com> (raw)
In-Reply-To: <20261117103916.9101-1-tvrtko.ursulin@igalia.com>

From: Fei Yu <fei.yu@intel.com>

On 11/17/26 10:39, Tvrtko Ursulin wrote:
> In practice there are multiple DRM syncobj operations (and/or ioctls) per
> rendered frame, and vast majority of them operates on a just a couple of
> handles, or timeline points.
>
> This series adds a fast path to avoid the temporary allocations for those cases.

Tested on next-20261117 (x86_64, KASAN + KASAN_STACK, lockdep,
kmemleak, virtio-gpu in QEMU), base and patched with the same config:

- IGT syncobj_basic, syncobj_wait, syncobj_timeline: 202/202 on both,
  identical per subtest, dmesg clean.
- A targeted test for 1..8 handles (both sides of
  DRM_SYNCOBJ_FAST_PATH_ENTRIES) on all six array ioctls: success,
  -ENOENT with the bad handle at every position, -EFAULT for bad /
  partially unmapped handle and point arrays, refcounts balanced;
  wait-all / wait-any woken by sw_sync fence callbacks and by
  WAIT_FOR_SUBMIT; -ETIME and -EINTR followed by signalling the
  fences afterwards (nothing left on the stack entries); 20 s
  wait vs. reset/signal/query stress. All pass, no splats, kmemleak
  clean.
- The 1M handle limit still holds: 1M real syncobjs succeed on all
  six ioctls, 1M + 1 returns -EINVAL.
- Every patch builds with W=1 and sparse clean, i386 too.

Note the series depends on 6ca87397aeeb ("drm/syncobj: Limit the
number of handles and use kvmalloc for user-sized arrays"), which is
in drm-misc-fixes only, so it doesn't apply to drm-misc-next yet.

Reviewed-by: Fei Yu <fei.yu@intel.com>
Tested-by: Fei Yu <fei.yu@intel.com>

Thanks,
Fei

      parent reply	other threads:[~2026-11-18  8:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 10:39 [PATCH 0/3] drm/syncobj: Allocation avoiding fast path Tvrtko Ursulin
2026-11-17 10:39 ` [PATCH 1/3] drm/syncobj: Use vmemdup_array_user in drm_syncobj_array_find Tvrtko Ursulin
2026-11-17 12:57   ` Maíra Canal
2026-11-17 13:23   ` Christian König
2026-11-17 10:39 ` [PATCH 2/3] drm/syncobj: Add a fast path to drm_syncobj_array_wait_timeout Tvrtko Ursulin
2026-11-18  8:06   ` Yu, Fei
2026-11-17 10:39 ` [PATCH 3/3] drm/syncobj: Add a fast path to drm_syncobj_array_find Tvrtko Ursulin
2026-11-18  8:06   ` Yu, Fei
2026-11-18  8:06 ` Yu, Fei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118080611.180520-1-fei.yu@intel.com \
    --to=fei.yu@intel.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-dev@igalia.com \
    --cc=mcanal@igalia.com \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.