From: Stefano Tondo <stondo@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Joshua Watt <JPEWhacker@gmail.com>,
Alexander Kanavin <alex.kanavin@gmail.com>,
Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,
Stefano Tondo <stondo@gmail.com>,
Stefano Tondo <stefano.tondo.ext@siemens.com>
Subject: [PATCH 3/4] spdx30: Add the PURLs of the source downloads to the output packages
Date: Wed, 18 Nov 2026 10:29:26 +0100 [thread overview]
Message-ID: <20261118092927.204959-4-stondo@gmail.com> (raw)
In-Reply-To: <20261118092927.204959-1-stondo@gmail.com>
From: Stefano Tondo <stefano.tondo.ext@siemens.com>
Statically linked code, for example a Rust crate, is part of the
binary, but the SPDX of the output package only names the recipe.
A vulnerability scanner that checks the packages of an image does
not find the dependency.
Add the PURLs of the source downloads to the external identifiers of
each output package. Leave out the crates that the cargo dependency
graph proves are not built into the target. The software_packageUrl
of the package stays the first PURL in SPDX_PACKAGE_URLS.
Signed-off-by: Stefano Tondo <stefano.tondo.ext@siemens.com>
---
meta/lib/oe/spdx30_tasks.py | 30 ++++++++++++++++++++++++++----
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/meta/lib/oe/spdx30_tasks.py b/meta/lib/oe/spdx30_tasks.py
index e40716a6df..441df709a4 100644
--- a/meta/lib/oe/spdx30_tasks.py
+++ b/meta/lib/oe/spdx30_tasks.py
@@ -526,16 +526,24 @@ def get_cargo_scopes(d):
def add_dependency_scopes(d, objset, build, source_files):
- """Give crate downloads a lifecycle scope, see get_cargo_scopes()."""
+ """Give crate downloads a lifecycle scope, see get_cargo_scopes().
+
+ Returns the crate downloads that are not built into the target: crates
+ that are not used on it, build scripts, proc-macros and the crates
+ they use, and test-only crates.
+ """
scopes = get_cargo_scopes(d)
if scopes is None:
- return
+ return set()
by_scope = {}
+ not_in_target = set()
for dl in source_files:
if not (getattr(dl, "software_packageUrl", None) or "").startswith("pkg:cargo/"):
continue
scope = scopes.get((dl.name, dl.software_packageVersion))
+ if scope != "runtime":
+ not_in_target.add(dl)
if scope:
by_scope.setdefault(scope, []).append(dl)
else:
@@ -554,6 +562,8 @@ def add_dependency_scopes(d, objset, build, source_files):
sorted(oe.sbom30.get_element_link_id(dl) for dl in dls),
)
+ return not_in_target
+
def add_download_files(d, objset):
inputs = set()
@@ -1057,8 +1067,20 @@ def create_spdx(d):
source_files = add_download_files(d, build_objset)
build_inputs |= source_files
+
+ # The output packages inherit the PURLs of the downloads they are built
+ # from, as the code of statically linked dependencies is in them. Only
+ # the downloads known not to be built into the target are left out.
+ not_in_target = set()
if bb.data.inherits_class("cargo", d):
- add_dependency_scopes(d, build_objset, build, source_files)
+ not_in_target = add_dependency_scopes(d, build_objset, build, source_files)
+ dependency_purls = sorted(
+ {
+ dl.software_packageUrl
+ for dl in source_files
+ if getattr(dl, "software_packageUrl", None) and dl not in not_in_target
+ }
+ )
recipe_spdx_license = add_license_expression(
d, build_objset, d.getVar("LICENSE"), license_data, [recipe_objset]
@@ -1171,7 +1193,7 @@ def create_spdx(d):
d.getVar("SPDX_PACKAGE_URLS:%s" % package)
or d.getVar("SPDX_PACKAGE_URLS")
or ""
- ).split()
+ ).split() + dependency_purls
set_purls(spdx_package, purls)
--
2.56.1
next prev parent reply other threads:[~2026-11-18 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 9:29 [PATCH 0/4] spdx30: identity and purls of dependency downloads Stefano Tondo
2026-11-18 9:29 ` [PATCH 1/4] spdx30: Take name, version and PURL of downloads from the fetcher Stefano Tondo
2026-11-18 9:29 ` [PATCH 2/4] spdx30: Record the lifecycle scope of crate dependencies Stefano Tondo
2026-11-18 9:29 ` Stefano Tondo [this message]
2026-11-18 9:29 ` [PATCH 4/4] oeqa/selftest: spdx: Test crate identity, scope and output PURLs Stefano Tondo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118092927.204959-4-stondo@gmail.com \
--to=stondo@gmail.com \
--cc=JPEWhacker@gmail.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=stefan.herbrechtsmeier@weidmueller.com \
--cc=stefano.tondo.ext@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.