From: Joshua Crofts <crofts@kernel.org>
To: Maximo Manriquez Lizarraga via B4 Relay
<devnull+DelaySystem.tubot.lat@kernel.org>
Cc: DelaySystem@tubot.lat, jic23@kernel.org,
Michael.Hennerich@analog.com, dlechner@baylibre.com,
gregkh@linuxfoundation.org, andy@kernel.org, nuno.sa@analog.com,
linux-iio@vger.kernel.org, krzk@kernel.org, linux@analog.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: iio: adc: ad7816: use dev_err_probe() for GPIO lookups
Date: Wed, 18 Nov 2026 11:10:30 +0100 [thread overview]
Message-ID: <20261118111030.00002090@kernel.org> (raw)
In-Reply-To: <20261117-batch1-s3-warn-v2-1-17f4e541123b@tubot.lat>
On Tue, 17 Nov 2026 16:06:03 -0800
Maximo Manriquez Lizarraga via B4 Relay <devnull+DelaySystem.tubot.lat@kernel.org> wrote:
> From: Maximo Manriquez Lizarraga <DelaySystem@tubot.lat>
>
> GPIO lookups can return -EPROBE_DEFER. Convert the rdwr and convert
> GPIO lookup failures in ad7816_probe() to dev_err_probe(), which
> suppresses the error message on deferral and records the deferral
> reason. The busy-GPIO path is left untouched: its optionality is the
> subject of a separate proposed change.
>
> No functional change other than defer handling.
>
> Signed-off-by: Maximo Manriquez Lizarraga <DelaySystem@tubot.lat>
> ---
> Changes in v2:
> - Resend under my real name (From/Signed-off-by: Maximo Manriquez Lizarraga).
> - Apologies for the improper sign-off on v1; no code change.
> - Link to v1: https://patch.msgid.link/20261107-batch1-s3-warn-v1-1-4fc38341ca38@tubot.lat
> ---
You've missed the following segment starting line 398:
if (chip->id == ID_AD7816 || chip->id == ID_AD7817) {
chip->busy_pin = devm_gpiod_get(&spi_dev->dev, "busy",
GPIOD_IN);
if (IS_ERR(chip->busy_pin)) {
ret = PTR_ERR(chip->busy_pin);
dev_err(&spi_dev->dev, "Failed to request busy GPIO: %d\n",
ret);
return ret;
Otherwise the existing changes are fine.
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-11-18 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 0:06 [PATCH v2] staging: iio: adc: ad7816: use dev_err_probe() for GPIO lookups Maximo Manriquez Lizarraga via B4 Relay
2026-11-18 0:06 ` Maximo Manriquez Lizarraga
2026-11-18 10:10 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118111030.00002090@kernel.org \
--to=crofts@kernel.org \
--cc=DelaySystem@tubot.lat \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=devnull+DelaySystem.tubot.lat@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.