From: SJ Park <sj@kernel.org>
To: Sailesh Nandanavanam <saileshnandanavanam@gmail.com>
Cc: SJ Park <sj@kernel.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/damon/tests/core-kunit: add test for damon_call()
Date: Wed, 18 Nov 2026 06:28:29 -0800 [thread overview]
Message-ID: <20261118142830.90113-1-sj@kernel.org> (raw)
In-Reply-To: <20261118063755.37749-1-saileshnandanavanam@gmail.com>
Hello Sailesh,
On Wed, 18 Nov 2026 12:07:55 +0530 Sailesh Nandanavanam <saileshnandanavanam@gmail.com> wrote:
> A newly allocated damon_ctx has call_controls_obsolete set, meaning no
> kdamond is available to handle call requests. damon_call() should
> return -ECANCELED in that case instead of queueing the request and
> waiting forever. When call_controls_obsolete is unset and
> damon_call_control->repeat is set, damon_call() should return 0
> without waiting for kdamond. Add a kunit test for the two cases.
>
> Signed-off-by: Sailesh Nandanavanam <saileshnandanavanam@gmail.com>
> ---
> Changes from v1
> (https://lore.kernel.org/20261117172219.26725-1-saileshnandanavanam@gmail.com,
> https://lore.kernel.org/20261117174834.29182-1-saileshnandanavanam@gmail.com)
> - Merge the two tests into damon_test_call().
> - Drop the list_empty()/call_controls.next expectations.
> - Drop list_del() on the stack-allocated control.
> - Post as a single patch.
From the next time, please ensure all discussions on the previous version is
done. You could do so by giving more time before posting a new version, since
the last message to the previous version thread is added.
[...]
> base-commit: 20eef29b7c8465ac98d7dd6d6f2ac07a8d8056ca
Seems this is the mainline. Please use mm-new [1] as the baseline of DAMON
patches from the next time.
Other than those,
Reviewed-by: SJ Park <sj@kernel.org>
This patch is applied to damon/next [1] tree. I will repost it soon (~1 week)
as an mm.git merge request. So, no action from your side is needed for now.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-11-18 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 6:37 [PATCH v2] mm/damon/tests/core-kunit: add test for damon_call() Sailesh Nandanavanam
2026-11-18 6:40 ` sashiko-bot
2026-11-18 10:30 ` Aveline Noir
2026-11-18 14:28 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118142830.90113-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=saileshnandanavanam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.