From: Rob Herring <robh@kernel.org>
To: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 3/3] usb: dwc3: select the shared HS data bus with a mux controller
Date: Wed, 18 Nov 2026 09:27:39 -0600 [thread overview]
Message-ID: <20261118152739.GA1824160-robh@kernel.org> (raw)
In-Reply-To: <20261117052137.32833-4-xiaqinghuan@mail.ustc.edu.cn>
On Tue, Nov 17, 2026 at 01:21:37PM +0800, Qianhui Xu wrote:
> Respond to Rob's review of v8: drop the private "port-select-gpios"
> property and drive the shared High Speed data path through a mux
> controller instead ("Use the gpio mux binding").
What changed in this version isn't really applicable for the commit
message. We don't need to record something about "port-select-gpios"
forever in the commit log.
The commit msg should answer "why" we need/want this change.
>
> The connector to drive is still published per endpoint via "mux-state";
> dwc3_role_mux_init() now requires the "mux-controls" property and gets
> the controller with devm_mux_control_get(). A mux controller cannot be
> read back, so the boot-time connector can no longer be detected: the
> initial mode request claims the mux for state 0 instead, which is the
> first mode request that reaches __dwc3_set_mode() after probe.
>
> mux_control_select() sleeps while waiting for the controller, and
> mux_control_deselect() may sleep as well. Both are only ever called
> from __dwc3_set_mode(), which runs as a work item on
> system_freezable_wq; the role-switch set() callback keeps recording the
> request and never touches the mux directly. The mux is kept selected
> between switches, since the controller always drives exactly one of the
> two connectors.
>
> This rework does not change the arbitration, the publication ordering
> or the teardown rules introduced in v7/v8.
>
> Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
> ---
What has changed in each version is useful for review and that goes here
after the '---'.
Rob
prev parent reply other threads:[~2026-11-18 15:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 5:21 [PATCH v9 0/3] usb: dwc3: support two connectors sharing one HS data bus Qianhui Xu
2026-11-17 5:21 ` [PATCH v9 1/3] dt-bindings: usb: snps,dwc3: two connectors are two endpoints of one port Qianhui Xu
2026-11-17 5:40 ` sashiko-bot
2026-11-18 15:34 ` Rob Herring
2026-11-17 5:21 ` [PATCH v9 2/3] usb: roles: look up role switches attached to a graph endpoint Qianhui Xu
2026-11-17 5:27 ` sashiko-bot
2026-11-17 5:21 ` [PATCH v9 3/3] usb: dwc3: select the shared HS data bus with a mux controller Qianhui Xu
2026-11-17 5:37 ` sashiko-bot
2026-11-18 15:27 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118152739.GA1824160-robh@kernel.org \
--to=robh@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=xiaqinghuan@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.