From: Simon Horman <horms@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: Jeremy.Jean@oss.cyber.gouv.fr, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net v2] udp_tunnel: fix GRO callback mismatch during setup
Date: Wed, 18 Nov 2026 15:32:21 +0000 [thread overview]
Message-ID: <20261118153221.GG860048@horms.kernel.org> (raw)
In-Reply-To: <179478310543.3136.4977357785981182737@kernel.org>
On Sun, Nov 15, 2026 at 10:51:45PM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 · Medium: 2 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The fix still lets receive and completion use different tunnel
> parsers on the same packet, so the out-of-bounds write the commit…
> - [Medium] udp_tunnel_gro_count only describes how the head skb of a GRO
> entry was parsed, not the packets merged into it, so packets in the…
> - [Medium] The Fixes: tag blames only 5d7f5b2f6b93 ("udp_tunnel: use
> static call for GRO hooks when possible", v6.16), but part of what the…
> - [Low] The new synchronize_net() in udp_tunnel_update_gro_rcv()
> (net/ipv4/udp_offload.c:139) runs with the global…
>
Hi Jérémy,
I would appreciate it if you could provide feedback on
the concerns raised in this AI-generated review.
next prev parent reply other threads:[~2026-11-18 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 21:46 [PATCH net v2] udp_tunnel: fix GRO callback mismatch during setup Jérémy Jean
2026-11-11 21:51 ` netdev-bot+sinfo
2026-11-11 21:58 ` Jérémy Jean
2026-11-15 22:51 ` netdev-bot+sashiko
2026-11-18 15:32 ` Simon Horman [this message]
2026-11-18 15:36 ` Jérémy Jean
2026-11-18 17:26 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118153221.GG860048@horms.kernel.org \
--to=horms@kernel.org \
--cc=Jeremy.Jean@oss.cyber.gouv.fr \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.