All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jani.nikula@intel.com, pranay.samala@intel.com,
	karthik.b.s@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t 8/8] tests/intel/i915_module_load: Verify driver unload result
Date: Wed, 18 Nov 2026 21:14:23 +0530	[thread overview]
Message-ID: <20261118154426.345883-9-jeevan.b@intel.com> (raw)
In-Reply-To: <20261118154426.345883-1-jeevan.b@intel.com>

Assert that igt_i915_driver_unload() succeeds in the reload, reload-no-display
and resize-bar paths, so a failed unload (including intel_display) is
reported instead of being ignored.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
 tests/intel/i915_module_load.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/intel/i915_module_load.c b/tests/intel/i915_module_load.c
index c875d2501..49dffadfe 100644
--- a/tests/intel/i915_module_load.c
+++ b/tests/intel/i915_module_load.c
@@ -285,7 +285,7 @@ static uint32_t  driver_load_with_lmem_bar_size(uint32_t lmem_bar_size, bool che
 	int i915 = -1;
 	char lmem_bar[64];
 
-	igt_i915_driver_unload();
+	igt_assert_eq(igt_i915_driver_unload(), 0);
 	if (lmem_bar_size == 0)
 		igt_assert_eq(igt_i915_driver_load(NULL), 0);
 	else {
@@ -621,7 +621,7 @@ int igt_main()
 
 	igt_describe("Verify the basic functionality of i915 driver after it's reloaded.");
 	igt_subtest("reload") {
-		igt_i915_driver_unload();
+		igt_assert_eq(igt_i915_driver_unload(), 0);
 
 		load_and_check_i915();
 
@@ -630,11 +630,11 @@ int igt_main()
 
 	igt_describe("Verify that i915 driver can be successfully loaded with disabled display.");
 	igt_subtest("reload-no-display") {
-		igt_i915_driver_unload();
+		igt_assert_eq(igt_i915_driver_unload(), 0);
 
 		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
 
-		igt_i915_driver_unload();
+		igt_assert_eq(igt_i915_driver_unload(), 0);
 	}
 
 	igt_describe("Test i915 fault injection");
@@ -683,7 +683,7 @@ int igt_main()
 		result_bar_size = driver_load_with_lmem_bar_size(lmem_bar_size, false);
 		igt_assert_f(lmem_bar_size != result_bar_size, "Bar resized to unsupported size.\n");
 
-		igt_i915_driver_unload();
+		igt_assert_eq(igt_i915_driver_unload(), 0);
 	}
 
 	/* Subtests should unload the module themselves if they use modparams */
-- 
2.43.0


  parent reply	other threads:[~2026-11-18 15:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 15:44 [PATCH i-g-t 0/8] RFC: Add intel_display module support to module load tests Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 1/8] lib/igt_params: Fall back to intel_display module parameters Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 2/8] tests/kms_panel_fitting: Find fastboot param with a dedicated display module Jeevan B
2026-11-19  9:13   ` Jani Nikula
2026-11-18 15:44 ` [PATCH i-g-t 3/8] tests/intel/i915_module_load: Check intel_display in load subtest Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 4/8] tests/intel/xe_module_load: Check intel_display in load subtests Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 5/8] lib/igt_kmod: Unload intel_display together with the GPU driver Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 6/8] tests/intel: Add intel_display_module_load test Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 7/8] tests/intel/xe_module_load: Verify driver unload result Jeevan B
2026-11-18 15:44 ` Jeevan B [this message]
2026-11-19  3:40 ` ✓ Xe.CI.BAT: success for RFC: Add intel_display module support to module load tests Patchwork
2026-11-19 12:46 ` ✗ i915.CI.BAT: failure " Patchwork
2026-11-20  3:40 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118154426.345883-9-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=pranay.samala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.