From: Jakub Kicinski <kuba@kernel.org>
To: Fan Gong <gongfan1@huawei.com>
Cc: Wu Di <wudi234@huawei.com>, Teng Peisen <tengpeisen@huawei.com>,
<netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Mohsin Bashir <mohsin.bashr@gmail.com>,
Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>,
Harshitha Ramamurthy <hramamurthy@google.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
"Vadim Fedorenko" <vadim.fedorenko@linux.dev>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>
Subject: Re: [PATCH net-next v04 1/4] hinic3: Fix the RX stalls in hinic3_rx_poll()
Date: Wed, 18 Nov 2026 18:09:07 -0800 [thread overview]
Message-ID: <20261118180907.641e8e51@kernel.org> (raw)
In-Reply-To: <85bd868ec35a5963c08193a3c1870aa87004f63d.1794917917.git.gongfan1@huawei.com>
On Tue, 17 Nov 2026 20:08:31 +0800 Fan Gong wrote:
> hinic3_rx_poll() can leave the loop with a completed CQE still sitting at
> the head of the ring, or with no WQE left to receive into, and still
> return nr_pkts, which is below budget. hinic3_poll() then calls
> napi_complete_done() and re-enables the MSI-X interrupt, which is edge
> triggered, so nothing re-arms the queue if no further packet arrives.
Look how you Hauwei coworker is fixing this in hns3:
https://lore.kernel.org/all/20261118130330.3026625-4-shaojijie@huawei.com/
That's much better. Live-locking the system in NAPI when its OOM
is pretty bad. My personal preference is to have a work that just
checks for Rx buffer queue being empty every few sec.
next prev parent reply other threads:[~2026-11-19 2:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 12:08 [PATCH net-next v04 0/4] net: hinic3: Bugfix for later patch-set Fan Gong
2026-11-17 12:08 ` [PATCH net-next v04 1/4] hinic3: Fix the RX stalls in hinic3_rx_poll() Fan Gong
2026-11-19 2:09 ` Jakub Kicinski [this message]
2026-11-19 8:04 ` Fan Gong
2026-11-17 12:08 ` [PATCH net-next v04 2/4] hinic3: Read the queue counters once per u64_stats retry loop Fan Gong
2026-11-17 12:08 ` [PATCH net-next v04 3/4] hinic3: Wrap long lines and rename q_params Fan Gong
2026-11-17 12:08 ` [PATCH net-next v04 4/4] hinic3: Keep max_qps at the hardware maximum when RSS setup fails Fan Gong
2026-11-19 2:20 ` [PATCH net-next v04 0/4] net: hinic3: Bugfix for later patch-set patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118180907.641e8e51@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dimitri.daskalakis1@gmail.com \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=ioana.ciornei@nxp.com \
--cc=larysa.zaremba@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tengpeisen@huawei.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wudi234@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.