All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Schwartz <matthew.schwartz@linux.dev>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: uma.shankar@intel.com, chaitanya.kumar.borah@intel.com,
	Matthew Schwartz <matthew.schwartz@linux.dev>
Subject: [RFC PATCH 0/2] drm/i915/color: 3D LUT fixes
Date: Wed, 18 Nov 2026 11:15:11 -0800	[thread overview]
Message-ID: <20261118191514.2931270-1-matthew.schwartz@linux.dev> (raw)

Two fixes for the 3D LUT support that came with the plane color
pipeline. I ran into both while bringing up the pipe-bound 3D LUT on
Lunar Lake for gamescope, using out-of-tree patches that expose it
through the CRTC color pipeline proposed in [1].

Patch 1 stops planes that do not own the 3D LUT from rewriting
LUT_3D_CTL. On Lunar Lake an enable bit set by hand is cleared by the
next plane update. Reading the code, the same write from any
non-primary plane on Xe3p_LPD disables the LUT the primary plane
enabled.

Patch 2 writes the table in the order the hardware reads it. The colorop
blob has red as the fastest axis and the hardware has blue. I measured
this on Lunar Lake only, with the LUT bound to the pipe, by writing
LUT_3D_INDEX and LUT_3D_DATA from userspace and decoding the pipe CRC of
solid color frames. I have no Nova Lake hardware, so the plane-bound
case is unchecked. If the plane binding indexes the table differently
this patch is wrong for it, and I would appreciate a pointer to what
Bspec says about the entry order.

[1] https://lore.kernel.org/all/20260716160556.227556-1-mwen@igalia.com/

Matthew Schwartz (2):
  drm/i915/color: only let the owning plane program the 3D LUT
  drm/i915/color: load the 3D LUT in the order the hardware indexes it

 drivers/gpu/drm/i915/display/intel_color.c    | 28 ++++++++++++++++---
 drivers/gpu/drm/i915/display/intel_color.h    |  5 ++++
 .../drm/i915/display/intel_color_pipeline.c   | 12 ++------
 3 files changed, 31 insertions(+), 14 deletions(-)


base-commit: fb078d17b966f7a24720b6e3a5de06d43c2e184a
-- 
2.56.1


             reply	other threads:[~2026-11-19 15:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 19:15 Matthew Schwartz [this message]
2026-11-18 19:15 ` [RFC PATCH 1/2] drm/i915/color: only let the owning plane program the 3D LUT Matthew Schwartz
2026-11-18 19:15 ` [RFC PATCH 2/2] drm/i915/color: load the 3D LUT in the order the hardware indexes it Matthew Schwartz
2026-11-19 17:51 ` ✓ CI.KUnit: success for drm/i915/color: 3D LUT fixes Patchwork
2026-11-19 17:53 ` [RFC PATCH 0/2] " Borah, Chaitanya Kumar
2026-11-19 18:28 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-11-19 22:50 ` ✓ i915.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118191514.2931270-1-matthew.schwartz@linux.dev \
    --to=matthew.schwartz@linux.dev \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.