All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: "Hans Ulli Kroll" <ulli.kroll@googlemail.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Myeonghun Pak" <mhun512@gmail.com>,
	"Eric Dumazet" <edumazet@kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v8 10/19] net: ethernet: cortina: Separate RX buffer capacity from free queue size
Date: Wed, 18 Nov 2026 20:49:54 +0000	[thread overview]
Message-ID: <20261118204954.GS860048@horms.kernel.org> (raw)
In-Reply-To: <20261112-gemini-ethernet-fixes-3-v8-10-f55bd43e02d3@kernel.org>

On Thu, Nov 12, 2026 at 02:30:25PM +0100, Linus Walleij wrote:
> Containing a retained hardware read pointer can force an order-15 free
> queue even when the configured RX rings need far fewer buffers. Filling
> that descriptor ring requires nearly 64 MiB of pages on systems with
> 32 to 128 MiB of RAM. Allocation failure persists across retries because
> the stopped DMA engine cannot advance the pointer.
> 
> Keep the descriptor geometry required by the retained pointer, but size
> the RX buffer budget from the configured port rings. Bound the posted
> occupancy and refill work by that budget, including after dropping the
> free queue lock to allocate a page. Size page metadata and the NAPI refill
> threshold from the same budget.
> 
> For a retained pointer of 16384 and a requested buffer order of 10, this
> keeps the 512 KiB descriptor ring but posts 2044 KiB of RX pages instead
> of 65532 KiB. No hardware pointer-reset behaviour is assumed.
> 
> Found by review and checked with a ring-geometry model covering every
> supported retained pointer and buffer order.
> 
> Fixes: 0bf8c8c94af2 ("net: ethernet: cortina: Normalize free queue pointers on rebuild")

Hi Linus,

I don't see this commit in net-next. Perhaps it is a local commit?

> Signed-off-by: Linus Walleij <linusw@kernel.org>

...

  parent reply	other threads:[~2026-11-18 20:49 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 13:30 [PATCH net-next v8 00/19] net: ethernet: cortina: Fix Gemini RX/TX buffer management Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 01/19] net: ethernet: cortina: Keep shared free queue parent-owned Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 02/19] net: ethernet: cortina: Keep ports bound for shared IRQ Linus Walleij
2026-11-16 14:45   ` netdev-bot+sashiko
2026-11-17  7:53     ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 03/19] net: ethernet: cortina: Drain free queue IRQ before resize Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 04/19] net: ethernet: cortina: Normalize free queue pointers on rebuild Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 05/19] net: ethernet: cortina: Correct free queue DMA mappings Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 06/19] net: ethernet: cortina: Index free queue fragments with XArray Linus Walleij
2026-11-16 14:45   ` netdev-bot+sashiko
2026-11-17  7:57     ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 07/19] net: ethernet: cortina: Preserve in-flight free queue pages Linus Walleij
2026-11-16 14:45   ` netdev-bot+sashiko
2026-11-17  7:59     ` Linus Walleij
2026-11-17  8:01     ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 08/19] net: ethernet: cortina: Rotate free queue page allocation Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 09/19] net: ethernet: cortina: Recycle claimed free queue pages Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 10/19] net: ethernet: cortina: Separate RX buffer capacity from free queue size Linus Walleij
2026-11-16 14:45   ` netdev-bot+sashiko
2026-11-17  8:04     ` Linus Walleij
2026-11-18 20:49   ` Simon Horman [this message]
2026-11-18 21:01     ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 11/19] net: ethernet: cortina: Validate RX fragment lengths Linus Walleij
2026-11-16 14:45   ` netdev-bot+sashiko
2026-11-17  8:07     ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 12/19] net: ethernet: cortina: Account RX buffer size in truesize Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 13/19] net: ethernet: cortina: Release partial RX frames on stop Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 14/19] net: ethernet: cortina: Scale Gemini RX queues to system memory Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 15/19] net: ethernet: cortina: Serialize TX completion statistics Linus Walleij
2026-11-16 14:45   ` netdev-bot+sashiko
2026-11-17  8:08     ` Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 16/19] net: ethernet: cortina: Scope RX statistics updates Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 17/19] net: ethernet: cortina: Drain RX coalescing timer on stop Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 18/19] net: ethernet: cortina: Reject TX rings smaller than retained pointers Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 19/19] net: ethernet: cortina: Fix ethtool statistics reads Linus Walleij
2026-11-16 14:45   ` netdev-bot+sashiko
2026-11-17  8:09     ` Linus Walleij
2026-11-17  8:12 ` [PATCH net-next v8 00/19] net: ethernet: cortina: Fix Gemini RX/TX buffer management Linus Walleij
2026-11-20  0:52   ` Jakub Kicinski
2026-11-20 10:26     ` Linus Walleij
2026-11-20 18:21       ` Jakub Kicinski
2026-11-20 18:39       ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118204954.GS860048@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linusw@kernel.org \
    --cc=mhun512@gmail.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ulli.kroll@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.