From: Antoni Pokusinski <apokusinski01@gmail.com>
To: vigneshr@ti.com, andi.shyti@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, aaro.koskinen@iki.fi,
andreas@kemnade.info, khilman@baylibre.com, rogerq@kernel.org,
tony@atomide.com, jmkrzyszt@gmail.com, sumit.semwal@linaro.org,
christian.koenig@amd.com, phasta@kernel.org
Cc: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org,
Antoni Pokusinski <apokusinski01@gmail.com>
Subject: [PATCH v2 3/4] i2c: omap: remove unused is_rdr and is_xdr function arguments
Date: Wed, 18 Nov 2026 21:52:06 +0100 [thread overview]
Message-ID: <20261118205213.88778-4-apokusinski01@gmail.com> (raw)
In-Reply-To: <20261118205213.88778-1-apokusinski01@gmail.com>
Both functions omap_i2c_{receive|transmit}_data() have unused arguments
is_{r|x}dr which can be deleted.
Signed-off-by: Antoni Pokusinski <apokusinski01@gmail.com>
---
drivers/i2c/busses/i2c-omap.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index f02d294db42a..3f7060d57a86 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -996,8 +996,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *omap)
return 0;
}
-static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes,
- bool is_rdr)
+static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes)
{
u16 w;
@@ -1017,8 +1016,7 @@ static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes,
}
}
-static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes,
- bool is_xdr)
+static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes)
{
u16 w;
@@ -1122,7 +1120,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
OMAP_I2C_BUFSTAT_REG) >> 8) & 0x3F;
}
- omap_i2c_receive_data(omap, num_bytes, true);
+ omap_i2c_receive_data(omap, num_bytes);
omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RDR);
continue;
}
@@ -1133,7 +1131,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
if (omap->threshold)
num_bytes = omap->threshold;
- omap_i2c_receive_data(omap, num_bytes, false);
+ omap_i2c_receive_data(omap, num_bytes);
omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RRDY);
continue;
}
@@ -1145,7 +1143,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
if (omap->fifo_size)
num_bytes = omap->buf_len;
- ret = omap_i2c_transmit_data(omap, num_bytes, true);
+ ret = omap_i2c_transmit_data(omap, num_bytes);
if (ret < 0)
break;
@@ -1160,7 +1158,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
if (omap->threshold)
num_bytes = omap->threshold;
- ret = omap_i2c_transmit_data(omap, num_bytes, false);
+ ret = omap_i2c_transmit_data(omap, num_bytes);
if (ret < 0)
break;
--
2.56.1
next prev parent reply other threads:[~2026-11-18 20:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 20:52 [PATCH v2 0/4] i2c: omap: add support for DMA Antoni Pokusinski
2026-11-18 20:52 ` [PATCH v2 1/4] dt-bindings: i2c: ti,omap4-i2c: Add DMA properties Antoni Pokusinski
2026-11-18 20:52 ` [PATCH v2 2/4] ARM: dts: am33xx-l4: Add missing DMAs for I2C controllers Antoni Pokusinski
2026-11-18 20:52 ` Antoni Pokusinski [this message]
2026-11-19 0:58 ` [PATCH v2 3/4] i2c: omap: remove unused is_rdr and is_xdr function arguments Andrew Davis
2026-11-18 20:52 ` [PATCH v2 4/4] i2c: omap: add DMA support Antoni Pokusinski
2026-11-18 21:10 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118205213.88778-4-apokusinski01@gmail.com \
--to=apokusinski01@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andreas@kemnade.info \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jmkrzyszt@gmail.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=phasta@kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.