All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Màxim Pedraza Padilla" <maximpedraza@gmail.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: "Neil Armstrong" <neil.armstrong@linaro.org>,
	"Jessica Zhang" <jesszhan0024@gmail.com>,
	"Jyri Sarha" <jyri.sarha@iki.fi>,
	"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Robert Foss" <rfoss@kernel.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/4] drm/tilcdc: Implement state readout support
Date: Wed, 18 Nov 2026 22:21:14 +0100	[thread overview]
Message-ID: <20261118212114.150992-1-maximpedraza@gmail.com> (raw)
In-Reply-To: <avs2dagfmQkv00H0@houat>

On Mon, Nov 16, 2026 at 06:12:50PM +0100, Maxime Ripard wrote:
> > - The channel order isn't stored, so RGB is reported for the adopted
> >   framebuffer. It doesn't change what's on screen.
>
> You mean RGB vs BGR? It's not available anywhere in a register?

Right, there's no swap bit in the LCDC. The order comes from the board
wiring, which the DT describes with blue-and-red-wiring, and the driver
already uses it to pick the format list. I'll use that in the readout
instead of always reporting RGB.

> > - tilcdc_crtc_mode_fixup() is undone to get the requested mode, but a
> >   positive sync can't be told from a mode that doesn't specify it.
>
> That's suprising as well, the polairity of signals is typically stored
> somewhere in a register.

It is, in RASTER_TIMING_2 (INVERT_HSYNC and INVERT_VSYNC), so the actual
polarity is read back fine. What's lost is the difference between a mode
that asks for DRM_MODE_FLAG_PHSYNC and one with no polarity flag at all:
both end up with the same register value, and the readout can only pick
one of them. I'll reword the commit message.

> You need to give some leeway there. It's unlikely you'll ever going to
> be an exact match for the mode being used due to clock rounding.
> [...]
> We handle that in tidss by looking for the closest rate match and see if
> it falls into the specified tolerance
> (dispc_find_closest_refresh_rate_from_clk). I always thought of it as
> something that could be turned into a helper, and it's what you should
> be using here.

Makes sense, I'll use the same approach in tilcdc, and see if it can be
turned into a common helper along the way.

> That part is
> https://lore.kernel.org/all/20261116-drm-no-more-config-reset-v2-43-0bb471f4d1e0@kernel.org/
> with hw_reset that sashiko pointed out

Ok, I'll drop it from my patch and base on top of that one.

Thanks,
Màxim

  reply	other threads:[~2026-11-18 21:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 14:27 [RFC PATCH 0/4] drm/tilcdc: Implement state readout Màxim Pedraza Padilla
2026-11-16 14:27 ` [RFC PATCH 1/4] drm/bridge: Add atomic_sro_install_state hook Màxim Pedraza Padilla
2026-11-16 16:58   ` Maxime Ripard
2026-11-16 14:27 ` [RFC PATCH 2/4] drm/panel: Implement state readout in the panel bridge Màxim Pedraza Padilla
2026-11-16 16:59   ` Maxime Ripard
2026-11-16 14:27 ` [RFC PATCH 3/4] drm/tilcdc: Implement state readout support Màxim Pedraza Padilla
2026-11-16 17:12   ` Maxime Ripard
2026-11-18 21:21     ` Màxim Pedraza Padilla [this message]
2026-11-20 14:01       ` Maxime Ripard
2026-11-16 14:27 ` [RFC PATCH 4/4] drm/panel: simple: Keep the enable GPIO as left by the bootloader Màxim Pedraza Padilla
2026-11-16 16:50 ` [RFC PATCH 0/4] drm/tilcdc: Implement state readout Maxime Ripard
2026-11-18 21:21   ` Màxim Pedraza Padilla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118212114.150992-1-maximpedraza@gmail.com \
    --to=maximpedraza@gmail.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jesszhan0024@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=jyri.sarha@iki.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.