All of lore.kernel.org
 help / color / mirror / Atom feed
From: Danilo Krummrich <dakr@kernel.org>
To: dakr@kernel.org, aliceryhl@google.com,
	daniel.almeida@collabora.com, airlied@gmail.com, simona@ffwll.ch,
	lossin@kernel.org, gary@garyguo.net, ojeda@kernel.org,
	boqun@kernel.org, bjorn3_gh@protonmail.com,
	a.hindborg@kernel.org, tmgross@umich.edu, tamird@kernel.org,
	acourbot@nvidia.com, work@onurozkan.dev
Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] rust: pin-init: internal: suppress multiple_bound_locations
Date: Thu, 19 Nov 2026 00:37:03 +0100	[thread overview]
Message-ID: <20261118233727.3147222-3-dakr@kernel.org> (raw)
In-Reply-To: <20261118233727.3147222-1-dakr@kernel.org>

The generated __drop_order_check() combines existential lifetime bounds
with inferred field outlives bounds.

For instance, for Tyr's Firmware, this places 'res: 'fw in the generic
parameter list and 'res: 'vm in the where clause, triggering Clippy's
multiple_bound_locations lint at the struct declaration.

Allow this style lint on the generated drop-order check. This preserves
all generated bounds and leaves the lint enabled for user-written code.

Cc: Gary Guo <gary@garyguo.net>
Fixes: 73cf61724648 ("rust: pin-init: internal: pin_data: support existential lifetimes")
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
---
 rust/pin-init/internal/src/pin_data.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/rust/pin-init/internal/src/pin_data.rs b/rust/pin-init/internal/src/pin_data.rs
index 08e11128d353..b3c487999270 100644
--- a/rust/pin-init/internal/src/pin_data.rs
+++ b/rust/pin-init/internal/src/pin_data.rs
@@ -1246,7 +1246,8 @@ fn generate_drop_order_check(dcx: &mut DiagCtxt, info: &StructInfo) -> TokenStre
 
     let struct_span = struct_name.span().resolved_at(Span::mixed_site());
     quote_spanned! {struct_span =>
-        #[allow(non_snake_case, unused)]
+        // Generated bounds can appear both on lifetime parameters and in the where clause.
+        #[allow(non_snake_case, unused, clippy::multiple_bound_locations)]
         fn __drop_order_check #impl_generics_with_field_lt (
             // This must be present so the function can *assume* the implied bounds on the erased
             // struct. For example, if the struct has `&'a T`, Rust will infer `T: 'a`; we still
-- 
2.56.1


  parent reply	other threads:[~2026-11-18 23:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 23:37 [PATCH 0/4] drm/tyr: use pin-init self-referential support Danilo Krummrich
2026-11-18 23:37 ` [PATCH 1/4] drm/tyr: name resource lifetimes after their types Danilo Krummrich
2026-11-19  2:08   ` Gary Guo
2026-11-19 10:34     ` Danilo Krummrich
2026-11-19 11:28       ` Gary Guo
2026-11-19 12:28         ` Danilo Krummrich
2026-11-19 12:56           ` Gary Guo
2026-11-19 13:57             ` Danilo Krummrich
2026-11-19 15:44               ` Alice Ryhl
2026-11-19 16:38                 ` Danilo Krummrich
2026-11-18 23:37 ` Danilo Krummrich [this message]
2026-11-19  2:23   ` [PATCH 2/4] rust: pin-init: internal: suppress multiple_bound_locations Gary Guo
2026-11-18 23:37 ` [PATCH 3/4] drm/tyr: use pin-init self-referential support Danilo Krummrich
2026-11-18 23:47   ` sashiko-bot
2026-11-18 23:37 ` [PATCH 4/4] drm/tyr: use ScopeGuard for firmware loading cleanup Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118233727.3147222-3-dakr@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.