From: Ding Feng <dingf3ng@gmail.com>
To: Christian Brauner <brauner@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>
Cc: Ding Feng <dingf3ng@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Naohiro Aota <naohiro.aota@wdc.com>,
Johannes Thumshirn <jth@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] fs, zonefs: ignore RLIMIT_FSIZE values above LLONG_MAX
Date: Thu, 19 Nov 2026 11:10:24 +0800 [thread overview]
Message-ID: <20261119031026.7985-1-dingf3ng@gmail.com> (raw)
generic_write_check_limits() and its zonefs copy store
rlimit(RLIMIT_FSIZE), an unsigned long, in a loff_t. A soft limit
between 2^63 and RLIM_INFINITY turns negative, and every write then
fails with -EFBIG and SIGXFSZ:
$ bash -c 'ulimit -f 9007199254740992; echo hi > /tmp/f'
File size limit exceeded
Patch 1 fixes the VFS helper (write, pwrite, writev and copy_file_range
paths). Patch 2 applies the same fix to zonefs.
Changes in v2:
- Hold the limit in a u64 instead of an unsigned long. On 32-bit,
"limit <= LLONG_MAX" was always true and clang W=1 warned, as the
kernel test robot reported and Damien pointed out.
- v1 patch 1 was applied to vfs-7.5.misc as bc0dc4379463; v2 patch 1
replaces it.
v1: https://lore.kernel.org/linux-fsdevel/20261117173129.61028-1-dingf3ng@gmail.com/
Tested on v7.4-rc3 (20eef29b7c84), arm64 tinyconfig in QEMU, with a
static test program that sets the soft RLIMIT_FSIZE, writes 2 bytes
and copies 10 bytes with copy_file_range():
soft limit unpatched patched
1024, 2^63-1 ok ok
2^63, 2^63+4096,
2^64-2 EFBIG (both) ok (both)
1 short write, then EFBIG (both kernels)
Built fs/read_write.o and fs/zonefs/file.o with clang 19 and W=1 for
arm (multi_v7_defconfig) and arm64 (defconfig): v1 gives the robot's
warning on arm, v2 gives none. The zonefs change is compile-tested only.
Jun-ichi Takimoto reported this in 2020 [1]; no fix followed. It came up
again while proving pwrite(2) against POSIX with Frama-C/WP.
[1] https://lore.kernel.org/linux-fsdevel/8F9EB913-3AC3-4D89-9DA3-427029F6D211@kba.biglobe.ne.jp/
Ding Feng (2):
fs: ignore RLIMIT_FSIZE above LLONG_MAX in
generic_write_check_limits()
zonefs: ignore RLIMIT_FSIZE above LLONG_MAX in
zonefs_write_check_limits()
fs/read_write.c | 9 +++++----
fs/zonefs/file.c | 9 +++++----
2 files changed, 10 insertions(+), 8 deletions(-)
--
2.55.0
next reply other threads:[~2026-11-19 3:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 3:10 Ding Feng [this message]
2026-11-19 3:10 ` [PATCH v2 1/2] fs: ignore RLIMIT_FSIZE above LLONG_MAX in generic_write_check_limits() Ding Feng
2026-11-19 3:28 ` Ding Feng
2026-11-19 10:01 ` Jan Kara
2026-11-19 3:10 ` [PATCH v2 2/2] zonefs: ignore RLIMIT_FSIZE above LLONG_MAX in zonefs_write_check_limits() Ding Feng
2026-11-20 15:45 ` Damien Le Moal
2026-11-19 19:07 ` (subset) [PATCH v2 0/2] fs, zonefs: ignore RLIMIT_FSIZE values above LLONG_MAX Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119031026.7985-1-dingf3ng@gmail.com \
--to=dingf3ng@gmail.com \
--cc=brauner@kernel.org \
--cc=dlemoal@kernel.org \
--cc=jack@suse.cz \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.