From: Greg KH <gregkh@linuxfoundation.org>
To: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org, sashal@kernel.org,
Mario Limonciello <mario.limonciello@amd.com>,
Nathan Blomquist <nblomquist@gmail.com>
Subject: Re: [PATCH] drm/amd/pm: track BACO state in the SMU v11 ArmD3 sequence
Date: Thu, 19 Nov 2026 15:22:27 +0100 [thread overview]
Message-ID: <2026111904-gloating-share-b28e@gregkh> (raw)
In-Reply-To: <20261119141944.2994497-1-alexander.deucher@amd.com>
On Thu, Nov 19, 2026 at 09:19:44AM -0500, Alex Deucher wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> On Navi1x/Sienna Cichlid with runtime PM, when the audio function is
> enabled, BACO entry and exit are delegated to PMFW by sending
> SMU_MSG_ArmD3 instead of going through smu_v11_0_baco_set_state().
> Unlike the v13/v14/v15 helpers, smu_v11_0_baco_set_armd3_sequence()
> does not update smu_baco->state, so the driver keeps reporting
> SMU_BACO_STATE_EXIT while the ASIC is armed for / sitting in BACO.
>
> At runtime resume amdgpu_device_baco_exit() checks
> amdgpu_device_supports_baco(), which ends up in
> smu_v11_0_get_bamaco_support(). Since the state never reads ENTER, the
> "already in BACO" shortcut is skipped and the live BACO feature bit is
> consulted instead. PMFW clears that bit once ArmD3(BACO) is armed, so
> the check reports "supported but not enabled", the exit fails with
> -ENOTSUPP and the ULPS ArmD3 message is never sent. The runtime resume
> caller ignores the error, and a later secondary bus reset leaves the
> device unreachable. This shows up on a Navi 23 being handed from amdgpu
> to vfio-pci:
>
> baco_enter: in_runpm=1 audio_enabled=1 armd3=1 baco_state=1 ret=0
> bamaco: state=1 ... feat supported=1 enabled=0 in_runpm=1
> baco_exit: supports=0 ...
> runtime resume: baco_exit ret=-524
>
> Update smu_baco->state in the helper, mirroring the v13 implementation,
> so the capability check short-circuits while in BACO.
>
> Reported-by: Nathan Blomquist <nblomquist@gmail.com>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/6076
> Tested-by: Nathan Blomquist <nblomquist@gmail.com>
> Fixes: 13d75eadfa1a ("drm/amd/pm: correct the runpm handling for BACO supported ASIC")
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> Link: https://patch.msgid.link/20261103141457.2558235-1-mario.limonciello@amd.com
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> (cherry picked from commit d515b2694eab5b35533c7fb7af5bddff53ff60d3)
> (cherry picked from commit a26ec190925733dd205507493e936e59dbcd2b19)
Really?
:)
What stable tree(s) is this for?
thanks,
greg "I hate the drm git tree" k-h
next prev parent reply other threads:[~2026-11-19 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 14:19 [PATCH] drm/amd/pm: track BACO state in the SMU v11 ArmD3 sequence Alex Deucher
2026-11-19 14:22 ` Greg KH [this message]
2026-11-19 15:35 ` Mario Limonciello
-- strict thread matches above, loose matches on Subject: below --
2026-11-03 14:14 Mario Limonciello
2026-11-03 16:32 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026111904-gloating-share-b28e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexander.deucher@amd.com \
--cc=mario.limonciello@amd.com \
--cc=nblomquist@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.