From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931D2606A330 for ; Thu, 19 Nov 2026 08:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.a=rsa-sha256 header.s=mail header.b=SBDjvhVH Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EDC9510E73F; Thu, 19 Nov 2026 08:16:22 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7861110E73F for ; Thu, 19 Nov 2026 08:16:16 +0000 (UTC) Received: from killaraus.ideasonboard.com (2001-14ba-7086-3000--a06.rev.dnainternet.fi [IPv6:2001:14ba:7086:3000::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D7FD44E6; Thu, 19 Nov 2026 09:13:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1795076026; bh=I9fIZdwUtwWaOxKGVX5tqYUG9uEmcE9FWv3jz1LdbZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SBDjvhVHPB97xZxJQgb9MqugDPRKfsvrtwFoiQ4CkPcjqRCwH3jjmawRiQz/1gvLN YTd8sHGz1L4bERyR5buBiG3NbCFwIIzzsmS/+HM7YmeGKfaCidE1hAxe667EW0s6H7 R7EplmmjrHSZQLv5jEF3eFTZPUi4CJ0a41+sX6G4= Date: Thu, 19 Nov 2026 10:16:13 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , dri-devel@lists.freedesktop.org, Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v4 20/20] drm/rcar-du: Allow VSP and writeback build with COMPILE_TEST=y Message-ID: <20261119081613.GO1923307@killaraus.ideasonboard.com> References: <20261118214518.29317-1-ville.syrjala@linux.intel.com> <20261118214518.29317-21-ville.syrjala@linux.intel.com> <20261118221114.GI1923307@killaraus.ideasonboard.com> <20261118223911.GJ1923307@killaraus.ideasonboard.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Hi Geert, On Thu, Nov 19, 2026 at 08:38:21AM +0100, Geert Uytterhoeven wrote: > On Wed, 18 Nov 2026 at 23:57, Ville Syrjälä wrote: > > On Thu, Nov 19, 2026 at 12:39:11AM +0200, Laurent Pinchart wrote: > > > On Thu, Nov 19, 2026 at 12:32:15AM +0200, Ville Syrjälä wrote: > > > > On Thu, Nov 19, 2026 at 12:11:14AM +0200, Laurent Pinchart wrote: > > > > > On Wed, Nov 18, 2026 at 11:45:17PM +0200, Ville Syrjala wrote: > > > > > > From: Ville Syrjälä > > > > > > > > > > > > Make DRM_RCAR_VSP selectable with COMPILE_TEST=y, and enable the hidden > > > > > > DRM_RCAR_WRITEBACK option by default, so the VSP and writeback code gets > > > > > > built for greater coverage. Builds fine on x86, x86_64, arm and arm64 at > > > > > > least. > > > > > > > > > > Let's see what build bots will report on more exotic architectures. I > > > > > may volunteer you to send a fix if I'm too busy when the builders start > > > > > yelling :-) > > > > > > > > > > > Cc: Laurent Pinchart > > > > > > Cc: Tomi Valkeinen > > > > > > Cc: Kieran Bingham > > > > > > Cc: Geert Uytterhoeven > > > > > > Cc: Magnus Damm > > > > > > Cc: linux-renesas-soc@vger.kernel.org > > > > > > Signed-off-by: Ville Syrjälä > > > > > > --- > > > > > > drivers/gpu/drm/renesas/rcar-du/Kconfig | 4 ++-- > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/drivers/gpu/drm/renesas/rcar-du/Kconfig b/drivers/gpu/drm/renesas/rcar-du/Kconfig > > > > > > index 80bd770ae0f6..5394f131c58f 100644 > > > > > > --- a/drivers/gpu/drm/renesas/rcar-du/Kconfig > > > > > > +++ b/drivers/gpu/drm/renesas/rcar-du/Kconfig > > > > > > @@ -76,7 +76,7 @@ config DRM_RCAR_MIPI_DSI > > > > > > select RESET_CONTROLLER > > > > > > > > > > > > config DRM_RCAR_VSP > > > > > > - bool "R-Car DU VSP Compositor Support" if ARM > > > > > > + bool "R-Car DU VSP Compositor Support" if ARM || COMPILE_TEST > > > > > > > > > > This will make it possible to disable the option when ARM64 && > > > > > COMPILE_TEST, which will break operation on Gen3 and up. It would be > > > > > best to avoid that. > > > > > > > > Break operation, as in when running on real hardware? > > > > People actually do that with COMPILE_TEST=y kernels? > > COMPILE_TEST=y kernels should still work. > > > > Hopefully not in production, but that may be the case during development > > > (I don't though, there are enough kernel options to deal with without > > > COMPILE_TEST). > > > > > > This should do: > > > > > > bool "R-Car DU VSP Compositor Support" if ARM || (COMPILE_TEST && !ARM64) > > > > > > (untested though). Do you think it brings too much complexity ? > > > > Doesn't bother me. > > It does bother me, as it breaks the safeguards encoded in Kconfig rules. > I think it would be better if DRM_RCAR_DU would select DRM_RCAR_VSP > if ARM64, so DRM_RCAR_VSP cannot be disabled where it is needed. That's possibly an option too. But does bool "R-Car DU VSP Compositor Support" if ARM || (COMPILE_TEST && !ARM64) break the safeguard ? -- Regards, Laurent Pinchart