From: Ido Schimmel <idosch@nvidia.com>
To: Jay Vosburgh <jv@jvosburgh.net>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@kernel.org, andrew+netdev@lunn.ch,
petrm@nvidia.com, sridhar.samudrala@intel.com, jiri@resnulli.us,
horms@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, razor@blackwall.org
Subject: Re: [PATCH net-next 2/6] bonding: 3ad: Notify Rx state changes
Date: Thu, 19 Nov 2026 11:03:40 +0200 [thread overview]
Message-ID: <20261119090340.GA1730641@shredder> (raw)
In-Reply-To: <528757.1795032015@famine>
On Wed, Nov 18, 2026 at 12:00:15PM -0800, Jay Vosburgh wrote:
> Ido Schimmel <idosch@nvidia.com> wrote:
>
> >When coupled control is disabled, a port in COLLECTING state is enabled
> >for collection, but not for distribution. However, drivers that offload
> >LAG are not notified when a port enters or leaves this state since the
> >bond only notifies them when the port's 'backup' flag changes.
> >
> >Fix by setting 'rx_enabled' in the LAG lower state information according
> >to the slave's 'rx_disabled' flag in 802.3ad mode and by notifying when
> >this flag changes. Track pending notifications using a separate bit
> >since 'should_notify' is toggled when the 'backup' flag changes.
> >
> >Reviewed-by: Petr Machata <petrm@nvidia.com>
> >Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> >---
> >
> >Notes:
> > Known issues that this patch does not address:
> >
> > 1. The new 'should_notify_rx' bit shares a bitfield with other slave
> > flags. The 802.3ad state machine writes them under the mode lock, while
> > a few other paths (e.g., the 'all_slaves_active' handler) write them
> > under RTNL only. This is not new.
> >
> > 2. When a port is disabled with BOND_SLAVE_NOTIFY_NOW, two notifications
> > are sent: one after the Tx state change and one after the Rx state
> > change. This is harmless.
>
> How do we know this is harmless? Isn't this a change of
> behavior that's visible to user space?
The change in behavior is one additional RTM_NEWLINK notification that
is identical to the previous one in a path that already generates
multiple such notifications. I don't see how it can be harmful.
next prev parent reply other threads:[~2026-11-19 9:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:34 [PATCH net-next 0/6] bonding: 3ad: Support independent control with LAG offload Ido Schimmel
2026-11-18 8:34 ` [PATCH net-next 1/6] net: Add Rx enabled state to LAG lower state information Ido Schimmel
2026-11-18 8:34 ` [PATCH net-next 2/6] bonding: 3ad: Notify Rx state changes Ido Schimmel
2026-11-18 20:00 ` Jay Vosburgh
2026-11-19 9:03 ` Ido Schimmel [this message]
2026-11-18 8:34 ` [PATCH net-next 3/6] mlxsw: Enable LAG collector independently of distributor Ido Schimmel
2026-11-19 9:19 ` netdev-bot+sashiko
2026-11-19 10:28 ` Ido Schimmel
2026-11-18 8:34 ` [PATCH net-next 4/6] selftests: bonding: Test notifications in COLLECTING state Ido Schimmel
2026-11-18 8:34 ` [PATCH net-next 5/6] bonding: 3ad: Advertise Collecting only after collection is enabled Ido Schimmel
2026-11-19 9:19 ` netdev-bot+sashiko
2026-11-19 11:36 ` Ido Schimmel
2026-11-18 8:34 ` [PATCH net-next 6/6] selftests: bonding: Test that Collecting is advertised after notification Ido Schimmel
2026-11-19 9:19 ` netdev-bot+sashiko
2026-11-19 10:01 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119090340.GA1730641@shredder \
--to=idosch@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.