From: Herve Codina <herve.codina@bootlin.com>
To: sashiko-bot@kernel.org
Cc: sashiko-reviews@lists.linux.dev, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v9 4/4] bus: simple-pm-bus: Populate child nodes at probe
Date: Thu, 19 Nov 2026 11:42:18 +0100 [thread overview]
Message-ID: <20261119114218.0a044688@bootlin.com> (raw)
In-Reply-To: <20261119091245.2c6c6528@bootlin.com>
Hi,
On Thu, 19 Nov 2026 09:12:45 +0100
Herve Codina <herve.codina@bootlin.com> wrote:
> Hi,
>
> On Mon, 09 Nov 2026 14:50:21 +0000
> sashiko-bot@kernel.org wrote:
>
...
> > commit 7ba99d9ea04b1e1a29eebc1e1525489b300fe107
> > Author: Herve Codina <herve.codina@bootlin.com>
> >
> > bus: simple-pm-bus: Populate child nodes at probe
> >
> > This commit updates simple_pm_bus_probe() to populate child devices for
> > transparent bus matches (such as simple-bus, simple-mfd, isa, and
> > arm,amba-bus) during probe, and skips runtime PM calls in
> > simple_pm_bus_depopulate() when runtime PM is not enabled.
> >
> > [Severity: Low]
> > In the commit message, this patch fixes the probe behavior for bus-only
> > devices where returning 0 without populating children caused
> > device_links_driver_bound() to create wrong fw_devlinks. Should the commit
> > message include a Fixes tag for 98e96cf80045 ("drivers: bus: simple-pm-bus:
> > Add support for probing simple bus only devices")?
>
> The commit 98e96cf80045 didn't introduce the issue nor change the behavior.
> The problem is there from the beginning. For fw_devlink child devices should
> be populated by at parent (bus) probe(). bus-only devices such as simple-bus
> can populate devices recursively skipping the parent bus probe() step.
> I don't see an obvious commit to point for a Fixes tag and so I don't plan
> to add a Fixes tag on the next iteration.
Actually found a commit for Fixes tag:
628b8ca3e915 ("bus: simple-pm-bus: Remove child devices when the bus is unbound")
Will add the Fixes tag with this one in the next iteration.
Best regards,
Hervé
prev parent reply other threads:[~2026-11-19 10:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 14:08 [PATCH v9 0/4] lan966x pci device: Add support for SFPs, simple-bus part Herve Codina
2026-11-09 14:08 ` [PATCH v9 1/4] bus: simple-pm-bus: Avoid inconsistencies between probe() and remove() Herve Codina
2026-11-09 14:08 ` [PATCH v9 2/4] bus: simple-pm-bus: Remove the remove() function Herve Codina
2026-11-09 14:08 ` [PATCH v9 3/4] bus: simple-pm-bus: Remove child devices when the bus is unbound Herve Codina
2026-11-09 14:08 ` [PATCH v9 4/4] bus: simple-pm-bus: Populate child nodes at probe Herve Codina
2026-11-09 14:50 ` sashiko-bot
2026-11-19 8:12 ` Herve Codina
2026-11-19 10:42 ` Herve Codina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119114218.0a044688@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.