All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Bryon Fryer <bryon@fryer.io>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@kernel.org,
	horms@kernel.org, jasowangio@gmail.com,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	pabeni@redhat.com, shuah@kernel.org, stable@vger.kernel.org,
	Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net 1/2] udp: restore outer transport header after tunnel GRO
Date: Thu, 19 Nov 2026 15:20:55 -0800	[thread overview]
Message-ID: <20261119152055.415dc942@kernel.org> (raw)
In-Reply-To: <20261112030708.1915665-2-bryon@fryer.io>

On Wed, 11 Nov 2026 22:07:07 -0500 Bryon Fryer wrote:
> @@ -948,6 +948,8 @@ int udp_gro_complete(struct sk_buff *skb, int nhoff,
>  		skb->encapsulation = 1;
>  		err = udp_sk(sk)->gro_complete(sk, skb,
>  				nhoff + sizeof(struct udphdr));
> +		if (!err)
> +			skb_set_transport_header(skb, nhoff);

IIUC only UDP bothers us because that's what virtio/tun supports but
isn't the header stale for every tunnel (eg GRE?) Should we not reset
this back in inet_gro_complete()/ipv6_gro_complete() ?

Maybe GRO experts prefer it here, dunno. An ACK from someone who
understands this code better than me would be good.

  parent reply	other threads:[~2026-11-19 23:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  3:07 [PATCH net 0/2] udp: preserve outer transport header after tunnel GRO Bryon Fryer
2026-11-12  3:07 ` [PATCH net 1/2] udp: restore " Bryon Fryer
2026-11-16 13:50   ` netdev-bot+sashiko
2026-11-19 23:20   ` Jakub Kicinski [this message]
2026-11-12  3:07 ` [PATCH net 2/2] selftests: net: check UDP tunnel GRO virtio offsets Bryon Fryer
2026-11-16 13:50   ` netdev-bot+sashiko
2026-11-20 14:50   ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119152055.415dc942@kernel.org \
    --to=kuba@kernel.org \
    --cc=bryon@fryer.io \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=jasowangio@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.