All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>,
	Mohammad Heib <mheib@redhat.com>
Cc: <patchwork-bot+netdevbpf@kernel.org>,
	Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
	<pabeni@redhat.com>, <edumazet@kernel.org>,
	<andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
	<fballuch@redhat.com>, <aleksandr.loktionov@intel.com>,
	<luoxuanqiang@kylinos.cn>
Subject: Re: [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-12 (i40e, iavf)
Date: Thu, 19 Nov 2026 16:02:46 -0800	[thread overview]
Message-ID: <20261119160246.69144537@kernel.org> (raw)
In-Reply-To: <8f362b3d-4b54-4337-af61-b7310d353507@intel.com>

On Thu, 19 Nov 2026 11:44:24 -0800 Jacob Keller wrote:
> >> I noticed that the entire series has been applied except for the first patch.
> >> Was it intentionally dropped?  
> > 
> > The patch did have a "high" comment but that one does really just say
> > "shouldn't you also fix this in ice" which to me shouldn't be a knock
> > against fixing i40e..
> 
> Ignore me :D I can't read. The comment was on a different patch than the
> one that didn't get applied.

But fuzzy-matching your reply - you're right, it was the sashiko comment
of course. It seem to have pointed out that there's plenty other places
that don't do what the commit msg describes as "All callers do this".

Mohammad, you are the author, it's your responsibility not Tony's to
answer the Sashiko review.

      reply	other threads:[~2026-11-20  0:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  0:45 [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-12 (i40e, iavf) Tony Nguyen
2026-11-13  0:45 ` [PATCH net 1/6] i40e: fix napi_disable hang in i40e_down() during firmware update Tony Nguyen
2026-11-17  0:47   ` netdev-bot+sashiko
2026-11-13  0:45 ` [PATCH net 2/6] i40e: fix freeing of TX rings on RX allocation failure Tony Nguyen
2026-11-13  0:45 ` [PATCH net 3/6] i40e: avoid resetting BQL state when freeing temporary Tx rings in set_ringparam Tony Nguyen
2026-11-17  0:47   ` netdev-bot+sashiko
2026-11-13  0:45 ` [PATCH net 4/6] iavf: fix QoS capabilities memory leak Tony Nguyen
2026-11-13  0:45 ` [PATCH net 5/6] iavf: fix ASQ command buffer leak on init failure Tony Nguyen
2026-11-13  0:46 ` [PATCH net 6/6] iavf: add missing PTP adjustment callbacks Tony Nguyen
2026-11-13  0:52 ` [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-12 (i40e, iavf) netdev-bot+sinfo
2026-11-19  2:00 ` patchwork-bot+netdevbpf
2026-11-19 12:24   ` Mohammad Heib
2026-11-19 17:31     ` Jacob Keller
2026-11-19 19:44       ` Jacob Keller
2026-11-20  0:02         ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119160246.69144537@kernel.org \
    --to=kuba@kernel.org \
    --cc=aleksandr.loktionov@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=fballuch@redhat.com \
    --cc=jacob.e.keller@intel.com \
    --cc=luoxuanqiang@kylinos.cn \
    --cc=mheib@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=patchwork-bot+netdevbpf@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.