From: Jakub Kicinski <kuba@kernel.org>
To: "Daniel Zahka" <daniel.zahka@gmail.com>
Cc: <netdev-bot+sashiko@kernel.org>, <alexanderduyck@fb.com>,
<kernel-team@meta.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@kernel.org>, <pabeni@redhat.com>,
<dimitri.daskalakis1@gmail.com>, <mohsin.bashr@gmail.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 3/4] eth: mpnic: sync unicast and multicast address lists
Date: Thu, 19 Nov 2026 16:15:30 -0800 [thread overview]
Message-ID: <20261119161530.0dc624d4@kernel.org> (raw)
In-Reply-To: <DMY9FTQ22U8T.JKYB4HL8J8PH@gmail.com>
On Wed, 18 Nov 2026 05:21:44 -0500 Daniel Zahka wrote:
> > Would it make sense to flush stale entries from both lists before either
> > add phase runs?
> >
>
> I see this more as a low severity issue, because having the device be in
> promiscuous mode when a slot is free is not incorrect, just not optimal.
>
> If anything I would probably just rerun __hw_addr_sync_dev() on the uc
> list again after the mc one, if the first call returned -ENOSPC. I
> didn't think that was really worth it when this same comment came up in
> local review though.
Ack, IIRC the MAC table is at least 100 addrs, so micro-optimizing
the ~128 -> 127 transition isn't worth the LoC.
next prev parent reply other threads:[~2026-11-20 0:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 21:11 [PATCH net-next 0/4] eth: mpnic: L2 address filtering Daniel Zahka
2026-11-16 21:11 ` [PATCH net-next 1/4] eth: mpnic: add filters for dev_addr and broadcast address Daniel Zahka
2026-11-16 21:11 ` [PATCH net-next 2/4] eth: mpnic: add promiscuous and all-multicast filters Daniel Zahka
2026-11-18 9:12 ` netdev-bot+sashiko
2026-11-18 10:04 ` Daniel Zahka
2026-11-16 21:11 ` [PATCH net-next 3/4] eth: mpnic: sync unicast and multicast address lists Daniel Zahka
2026-11-18 9:12 ` netdev-bot+sashiko
2026-11-18 10:21 ` Daniel Zahka
2026-11-20 0:15 ` Jakub Kicinski [this message]
2026-11-16 21:11 ` [PATCH net-next 4/4] eth: mpnic: support changing the MAC address Daniel Zahka
2026-11-20 0:20 ` [PATCH net-next 0/4] eth: mpnic: L2 address filtering patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119161530.0dc624d4@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=dimitri.daskalakis1@gmail.com \
--cc=edumazet@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.