All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Tiffany Lin <tiffany.lin@mediatek.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Yunfei Dong <yunfei.dong@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	Chen-Yu Tsai <wenst@chromium.org>,
	Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: Kyrie Wu <kyrie.wu@mediatek.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] media: dt-bindings: mediatek,vcodec-subdev-decoder: Fix child node if/then schemas
Date: Thu, 19 Nov 2026 13:10:55 -0600	[thread overview]
Message-ID: <20261119191055.GA3803102-robh@kernel.org> (raw)
In-Reply-To: <20261019212431.4109371-1-robh@kernel.org>

On Mon, Oct 19, 2026 at 04:24:29PM -0500, Rob Herring (Arm) wrote:
> The if/then schemas in mediatek,vcodec-subdev-decoder are all at the
> wrong level as they apply to child nodes. The clock-names schemas
> applies to the parent node, but the clock-names properties are in the
> child nodes. Move the clock-names definitions to the child node
> clock-names property. This exposes that the MT8186 clocks are not
> documented, so add them as well.
> 
> The interrupts if/then schema is never true as the parent compatible
> will never match the child compatible. The subschema also belongs in the
> child node.
> 
> Fixes: 3fbf1eac01b5 ("media: dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings for lat soc")
> Closes: https://sashiko.dev/#/bug/linux-5ab90035-1914-412f-8310-097fb05bda15
> Fixes: 355e9472ccb0 ("media: dt-bindings: media: mediatek: vcodec: adapt to the 'clock-names' of different platforms")
> Closes: https://sashiko.dev/#/bug/linux-caa6adb1-38de-4889-9517-2beede7c8f96
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../media/mediatek,vcodec-subdev-decoder.yaml | 77 ++++++++-----------
>  1 file changed, 31 insertions(+), 46 deletions(-)

Ping! This one needs to be applied before 2 other series posted.

> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> index d1d209cbbd43..6033ecffd707 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> @@ -135,8 +135,26 @@ patternProperties:
>          maxItems: 5
>  
>        clock-names:
> -        minItems: 4
> -        maxItems: 5
> +        oneOf:
> +          - description: MT8186 clocks
> +            items:
> +              - const: vdec-sel
> +              - const: vdec-soc-vdec
> +              - const: vdec
> +              - const: vdec-top
> +          - description: MT8192 clocks
> +            items:
> +              - const: sel
> +              - const: soc-vdec
> +              - const: soc-lat
> +              - const: vdec
> +              - const: top
> +          - description: MT8195 clocks
> +            items:
> +              - const: sel
> +              - const: vdec
> +              - const: lat
> +              - const: top
>  
>        assigned-clocks:
>          maxItems: 1
> @@ -159,6 +177,17 @@ patternProperties:
>  
>      additionalProperties: false
>  
> +    if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mediatek,mtk-vcodec-core
> +              - mediatek,mtk-vcodec-lat
> +    then:
> +      required:
> +        - interrupts
> +
>  required:
>    - compatible
>    - reg
> @@ -166,50 +195,6 @@ required:
>    - mediatek,scp
>    - ranges
>  
> -if:
> -  properties:
> -    compatible:
> -      contains:
> -        enum:
> -          - mediatek,mtk-vcodec-core
> -          - mediatek,mtk-vcodec-lat
> -
> -then:
> -  required:
> -    - interrupts
> -
> -allOf:
> -  - if:
> -      properties:
> -        compatible:
> -          contains:
> -            enum:
> -              - mediatek,mt8192-vcodec-dec
> -    then:
> -      properties:
> -        clock-names:
> -          items:
> -            - const: sel
> -            - const: soc-vdec
> -            - const: soc-lat
> -            - const: vdec
> -            - const: top
> -
> -  - if:
> -      properties:
> -        compatible:
> -          contains:
> -            enum:
> -              - mediatek,mt8195-vcodec-dec
> -    then:
> -      properties:
> -        clock-names:
> -          items:
> -            - const: sel
> -            - const: vdec
> -            - const: lat
> -            - const: top
> -
>  additionalProperties: false
>  
>  examples:
> -- 
> 2.53.0
> 
> 


      reply	other threads:[~2026-11-19 19:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 21:24 [PATCH] media: dt-bindings: mediatek,vcodec-subdev-decoder: Fix child node if/then schemas Rob Herring (Arm)
2026-11-19 19:10 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119191055.GA3803102-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=allen-kh.cheng@mediatek.com \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kyrie.wu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=tiffany.lin@mediatek.com \
    --cc=wenst@chromium.org \
    --cc=yunfei.dong@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.