From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795116342; b=uduwP/FSu2ddMk2NojUKK4IZI9ki3SLmfx5Fw3dNdME17d10x1ejbg/vFle36mQRfIZe 7BxJPpjEAh5x4c0P4hfzj+2kGSBjT9HEedAbwrLfU3xrKhhHDLCuIvMmn2/aNDKlE1AI9 xEF5/M5Xhdx2NG4Wda5Ki5zmftcfDJhAc5gxyE5tVp2mEuz60KEOHl20wC1z/vSWgJwDw hBjx2C0ZihLd8x/TMj0/IMTK5sCxBFmKYW5tflQrL7EzO5F6sYaIof4DQrsXBKSN+obdl 6xiOVO3CAwV6Nh13LdndNmwqUq5JVxM3t041OUJBPihrbIZj4P4/wnuknCpydPt37rQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795116342; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=ALLBk8MdTkFwcPZqYQO+ZVSicu8jJEanZFGqZFoBPVY=; b=OSqIJyFIZxx7KjspflObwHQxqvQHXibBDXS0+ge6wTQ0+BZj4BvobxS8+JrNEu3QJi1M JyNay4hZFNAJRRfBw9YufFOkbCtz45pVJ9kjFAaYLaUucgp/Rdtwf1sNrsViH8X1bnFyk T3HPQR0FZ1VnvDCYVXZdWAg+2/sXzzaRwIn1QUmBkAPkMO6Fu/MWCRu1o5BPUMI+fJdHF n+4P2CxBg4Yq4FXHJGCuIEmIp/tydYDuPnsLncoA0KoInK5/CbYcTWma7CGcmi3dwMmwm i94trrziOhcYJ6dj/EGHpXgb2B7uiCypRPCuIgCLk4cpQs8bediAbQkK8lD/ePtTK6w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=mpXAv5bq; arc=none smtp.remote-ip=209.85.214.200 Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0326160A2626 for ; Thu, 19 Nov 2026 19:25:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0326160A2626 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=mpXAv5bq Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2f0381f07a0so434595ad.1 for ; Thu, 19 Nov 2026 11:25:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795116341; x=1795721141; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ALLBk8MdTkFwcPZqYQO+ZVSicu8jJEanZFGqZFoBPVY=; b=mpXAv5bqYApX6ypwPk8eAHqRcGIsXHopmncKcik6Xj7H/NDLc1vp67RC4lIPu5sfnZ SHyikXWPtgDu0IY/I9UVMyIzu6AqELYB6LcGGFNdllfx04519afVqG8cAYjIq8calyqN hndI+15X5H7CdtEyurdVV4FA3QuTx8LxRmi0bsKMO+n6FIYg3M9DJVm3Sz3F2Hj9BxrJ gZqAbXmdpM+CUqYqof4rVHhDBv1myGNNVsvy3b+Xxs5Np+0zEKeEKVnYA2k58boGsvEY 0Ih7Z8tUHQQjb2Z4sfAmuXl+wjO/ZDjG7YD+lSScTMDJvrCmFS/1815tpkPZDc54DC8A kJEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795116341; x=1795721141; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ALLBk8MdTkFwcPZqYQO+ZVSicu8jJEanZFGqZFoBPVY=; b=peSo/w9TxH6YwBnzeEylWtFyDmF0yOnNznrMgUH03MBLua1PbVHjo2n7QbDASoF9Nl gITVgcThWgWRzwpUwr4QQX74plpN09LD8zPFrasfvGSFgEBQlQ2h7pgSiMDLZ7MOPfc1 YioeXrT7KERtPNPW7At8UAmUysIDCi7Fqd94LmKkc2zaAN6Zkpkd6eURLPrVncpttFdI cPumrgvKbxga1jCQQxKuKlLQgszkiGcFfMZCsdnsr47lgcyJ+Yjc4V3m5gKmSTbWD9N0 p6cgQZ6596+LKfFEvC9MioPLs4WV28L+FkmiGFVR/EqITqmFP8cvPOy7N0DlUEpZYRpI NtiQ== X-Forwarded-Encrypted: i=1; AL+hErFhCI5so6AYwDUWecBg5kbu1I6H+LIY+KPDqho9q3AFNLd2tRAFPhQDjM0cqX8EP1dqSXbR@lists.linux.dev X-Gm-Message-State: APuU4Z9tbYkCbigiPq+B5BEOMuM4wU+llVnI8o55HC/kRopxd3aIiQON Brh4prJLsOCR1Gkf/udIJd2CWU8+4Syp6Z9BkcZzMq7SxnzRuCZu93TMI/2xwoJzehB6FwnUC2H /mpSLEm4GTA== X-Received: from pleu15.prod.google.com ([2002:a17:903:41cf:b0:2ef:d860:1c85]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:fda5:b0:2ed:fb0:bfd6 with SMTP id d9443c01a7336-2f031e08699mr15736045ad.11.1795116341051; Thu, 19 Nov 2026 11:25:41 -0800 (PST) Date: Thu, 19 Nov 2026 11:25:14 -0800 In-Reply-To: <20261119192520.1983406-1-irogers@google.com> X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261119192520.1983406-1-irogers@google.com> X-Mailer: git-send-email 2.56.1.750.gf70dc682cf-goog Message-ID: <20261119192520.1983406-4-irogers@google.com> Subject: [PATCH v4 3/9] sh: sq: Add missing kobject release callback to ktype_percpu_entry From: Ian Rogers To: Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Srish Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Mimi Zohar , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with kzalloc_obj() and initialized with ktype_percpu_entry. When sq_dev_remove() calls kobject_put(kobj), the kobject is never freed because ktype_percpu_entry lacks a .release callback. Provide a sq_kobj_release() callback that calls kfree(kobj). Fixes: d7c30c682a27 ("sh: Store Queue API rework.") Acked-by: John Paul Adrian Glaubitz Signed-off-by: Ian Rogers --- arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c index 908a8e09113b..f33864958487 100644 --- a/arch/sh/kernel/cpu/sh4/sq.c +++ b/arch/sh/kernel/cpu/sh4/sq.c @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops = { .store = sq_sysfs_store, }; +static void sq_kobj_release(struct kobject *kobj) +{ + kfree(kobj); +} + static struct kobj_type ktype_percpu_entry = { + .release = sq_kobj_release, .sysfs_ops = &sq_sysfs_ops, .default_groups = sq_sysfs_groups, }; -- 2.56.1.708.g77570a6a1d-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 421EF606A333 for ; Thu, 19 Nov 2026 19:25:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Yedo5qo8; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=T9Vx1zBI DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Unsubscribe-Post:List-Owner; bh=/L/7gHmao4KGgJQZdnGR3J6GENHb1X4+tkjX3OjWu8k=; b=Yedo5qo8Ijup+pJy8/X/pd05XT tt9yJUlWyWqqD2eJzBhGs/pRWbKn8T712zx7hhsWfjpdz2/Ru96nl9hLDbvk/eOIg26ICDY97expK TU69YIY+RXHcJCgf33a+FCF+N1pUD8ezAMy5UGgocd85tTGW1EGXJx3b4CQju7Ki7NlInjR+wBJGa OyUPPRi9dx8JuPNhN4X5z+pGaMlXYpEktCVjLrm2mCFEbx6F14+Td2FpDwZf9npyEBYOLLGK0HZek MejWX+M0y0iT6qji2teNBSjpytyD2mxECoLSzszdxRui5zjjnSmypTmZqVOmhAgSz2EUH5C6FSIt7 wiIsqy/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU7lR-0000000DC0Q-43hR; Thu, 19 Nov 2026 19:25:45 +0000 Received: from mail-pl1-x645.google.com ([2607:f8b0:4864:20::645]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU7lO-0000000DBwx-2jNU for linux-mtd@lists.infradead.org; Thu, 19 Nov 2026 19:25:44 +0000 Received: by mail-pl1-x645.google.com with SMTP id d9443c01a7336-2f022026e60so597125ad.0 for ; Thu, 19 Nov 2026 11:25:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795116341; x=1795721141; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ALLBk8MdTkFwcPZqYQO+ZVSicu8jJEanZFGqZFoBPVY=; b=T9Vx1zBIsHHezLElGdrxtEY645KuRlEVZRpCbP45GqMvGICf21zGdL8escx8puoXTO v2hOp3E7gOdH1/38faCgzi0JLzar53jiSrIXWgCydtwnnULFyBZtT1cCAyRSrjokDThF 7bQHi0kOe32aNZwOgSlJLkH/6qhI/V4qjX5j8ZJMXuDp9UK+6PjebJt1qnnOtzhjHi+7 2bI0kqVGP2GYx9h4O6eThnZgn0bVIU+hPNUgh/Xsz7vX5NLFmNmIE4KgXrzWpgIB0Fh1 N+8+xng+xF84DQ/QGzyPd25xV18enIIFSCLeOsLFQWZv6/c3iIW0xX1nQ+0qY7nX9fea yxsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795116341; x=1795721141; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ALLBk8MdTkFwcPZqYQO+ZVSicu8jJEanZFGqZFoBPVY=; b=km53Hw34cnKF5UyulrH6ZgArQyWfQqH+mCW+/N5zcEFFyD4aYPLoGVGdnyas86oehO jF/EqBWtSc5wCFjDz31l4VhYn54mQPIFC1rV43FBKfZezUNYbAWu/tttxi4a4ibMy0mG sGz2PDwKXSI5w+6Gjr1JJqlWn6gzwW7LDvKX6PKYwTL+8MgnaasOvYWYujKzvog192Dd KIt9KfHPrl3I4uHOV7ofEO1M9+xJ9EtFQqhoJ5JA944L87UFnjl/zWTr0l0ZldOV8h2c OxTfjFHOO6IHsmoe5OTPEN+sY2/DWUGNlLTBjGI7mTpAqWzUFYH+kmMSkixN0Shq0uWc CMyA== X-Forwarded-Encrypted: i=1; AL+hErEfnFYtF6Ie+O6kTA5GyykHqTahssZzQnHu9qWPWPsJ8C3LOMgXaYe5qxp08KL3S0sahAXKOGIGE3w=@lists.infradead.org X-Gm-Message-State: APuU4Z+4zJhX+PnzP8goF1v5laNMoYMnfxzSOwxjGvYcmJjPJ3geiSPX SGDLeLf5kcrL+ua7Fk4XyVkCcRqprkJP+EbdT1Cvsy+r4CiL/5/ITOYAMUTDjVKvqAbtlQQKOmF vfJrflRqtgw== X-Received: from pleu15.prod.google.com ([2002:a17:903:41cf:b0:2ef:d860:1c85]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:fda5:b0:2ed:fb0:bfd6 with SMTP id d9443c01a7336-2f031e08699mr15736045ad.11.1795116341051; Thu, 19 Nov 2026 11:25:41 -0800 (PST) Date: Thu, 19 Nov 2026 11:25:14 -0800 In-Reply-To: <20261119192520.1983406-1-irogers@google.com> X-Archived-By: Mime-Version: 1.0 References: <20261119192520.1983406-1-irogers@google.com> X-Mailer: git-send-email 2.56.1.750.gf70dc682cf-goog Message-ID: <20261119192520.1983406-4-irogers@google.com> Subject: [PATCH v4 3/9] sh: sq: Add missing kobject release callback to ktype_percpu_entry From: Ian Rogers To: Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Srish Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Mimi Zohar , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261119_112542_703132_EE0DECF8 X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -9.5 (---------) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with kzalloc_obj() and initialized with ktype_percpu_entry. When sq_dev_remove() calls kobject_put(kobj), the kobject is never freed because ktype_percpu_entry lacks a .release callback. Provide a sq_kobj_release() callback that calls kfree(kobj). Fixes: d7c30c682a27 ("sh: Store Queue API rework.") Acked-by: John Paul Adrian Glaubitz Signed-off-by: Ian Rogers --- arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c index 908a8e09113b..f33864958487 100644 --- a/arch/sh/kernel/cpu/sh4/sq.c +++ b/arch/sh/kernel/cpu/sh4/sq.c @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops = { .store = sq_sysfs_store, }; +static void sq_kobj_release(struct kobject *kobj) +{ + kfree(kobj); +} + static struct kobj_type ktype_percpu_entry = { + .release = sq_kobj_release, .sysfs_ops = &sq_sysfs_ops, .default_groups = sq_sysfs_groups, }; -- 2.56.1.708.g77570a6a1d-goog ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/