All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Habil Eren Türker" <habilerenturker@hotmail.com>
Cc: Clemens Ladisch <clemens@ladisch.de>,
	Arnd Bergmann <arnd@arndb.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"syzbot+fc3a448093c17a792368@syzkaller.appspotmail.com"
	<syzbot+fc3a448093c17a792368@syzkaller.appspotmail.com>
Subject: Re: [PATCH RESEND] char/hpet: Fix missing TASK_RUNNING before put_user() in hpet_read()
Date: Thu, 19 Nov 2026 16:02:07 +0100	[thread overview]
Message-ID: <2026111926-finisher-captivity-64ce@gregkh> (raw)
In-Reply-To: <20261117111633.52928-1-habilerenturker@hotmail.com>

On Tue, Nov 17, 2026 at 11:16:37AM +0000, Habil Eren Türker wrote:
> hpet_read() sets the current task state to TASK_INTERRUPTIBLE within
> the read loop. However, when data becomes available, it exits the loop
> without restoring the TASK_RUNNING state. The subsequent put_user()
> operation may go to sleep due to a page fault, which triggers:
> 
>         do not call blocking ops when !TASK_RUNNING; state=1 set at
>         [<ffffffff85b6d1eb>] hpet_read+0x21b/0x6a0 drivers/char/hpet.c:285
> 
>         WARNING: kernel/sched/core.c:9187 at __might_sleep+0x94/0xc0
>         kernel/sched/core.c:9187, CPU#0: syz.0.873/9126
> 
>         Call Trace:
>         __might_fault+0x8b/0x140 mm/memory.c:7480
>         hpet_read+0x56f/0x6a0 drivers/char/hpet.c:309
>         do_loop_readv_writev fs/read_write.c:848 [inline]
>         do_loop_readv_writev fs/read_write.c:836 [inline]
>         vfs_readv+0x5d8/0x8d0 fs/read_write.c:1021
>         do_preadv+0x1ac/0x270 fs/read_write.c:1133
>         do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
>         do_syscall_64+0x123/0x790 arch/x86/entry/syscall_64.c:84
>         entry_SYSCALL_64_after_hwframe+0x77/0x7f
> 
> Restore TASK_RUNNING before breaking out of the loop.
> 
> Reported-by: syzbot+fc3a448093c17a792368@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=fc3a448093c17a792368
> Signed-off-by: Habil Eren Türker <habilerenturker@hotmail.com>
> ---
>  drivers/char/hpet.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index 285c6037417a..7ad319c6d942 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -290,6 +290,7 @@ hpet_read(struct file *file, char __user *buf, size_t count, loff_t * ppos)
>  		spin_unlock_irq(&hpet_lock);
>  
>  		if (data) {
> +			__set_current_state(TASK_RUNNING);

Shouldn't this be set_current_state(TASK_RUNNING) instead?

And why hasn't this ever been noticed before, what changed to cause it
to show up now?  And because of that, why is there not a Fixes: tag?

thanks,

greg k-h

  reply	other threads:[~2026-11-19 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:16 [PATCH RESEND] char/hpet: Fix missing TASK_RUNNING before put_user() in hpet_read() Habil Eren Türker
2026-11-19 15:02 ` Greg Kroah-Hartman [this message]
2026-11-19 18:28   ` Habil Eren Türker
2026-11-19 21:16     ` Arnd Bergmann
2026-11-20  9:01       ` Habil Eren Türker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026111926-finisher-captivity-64ce@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=clemens@ladisch.de \
    --cc=habilerenturker@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+fc3a448093c17a792368@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.